Skip to content

feat(checkout): CHECKOUT-10352 Swap phone LD experiment with a checkout setting - #3287

Draft
bc-maxy wants to merge 2 commits into
masterfrom
checkout-10352
Draft

feat(checkout): CHECKOUT-10352 Swap phone LD experiment with a checkout setting#3287
bc-maxy wants to merge 2 commits into
masterfrom
checkout-10352

Conversation

@bc-maxy

@bc-maxy bc-maxy commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What/Why?

Once we merge the SDK side: bigcommerce/checkout-sdk-js#3380
We can then just use a checkout setting instead of a LD flag to control rendering of new phone validation.

Since this is a controlled rollout which customers can opt-in or -out themselves, I also removed all other restrictions that we had previously in place like not rendering the component for Paypal Braintree merchants or not rendering when merchants set maxLength limits or placeholders on phone input fields.

Rollout/Rollback

Revert the PR

Testing

Updated CI tests.


Note

Medium Risk
Changes checkout address phone input behavior for merchants who enable the setting, including PayPal Fastlane and fields with max length/placeholders; rollout is setting-controlled but affects a core checkout form path.

Overview
Replaces the LaunchDarkly experiment CHECKOUT-9019.use_new_phone_number_validation with the checkout setting isPhoneNumberValidationEnabled (default off when missing) to control the IntlTelInput-based phone field on address forms.

AddressForm no longer special-cases PayPal Fastlane custom checkout or reads providerWithCustomCheckout for phone rendering; only the new setting gates the validated phone UI.

DynamicFormFieldSelector always uses PhoneFormField for telephone fields when the setting is on, including when merchants configure maxLength or a placeholder—those cases previously forced the legacy tel input. Props are renamed from isNewPhoneValidationExperimentEnabled to isPhoneNumberValidationEnabled through the form field stack, with tests updated to match.

Reviewed by Cursor Bugbot for commit 0676b2b. Bugbot is set up for automated code reviews on this repo. Configure here.

@bc-maxy

bc-maxy commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0676b2b. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant