'Units' value must be singular, not plural (year not years)#553
Merged
yarikoptic merged 2 commits intobids-standard:masterfrom Apr 16, 2026
Merged
'Units' value must be singular, not plural (year not years)#553yarikoptic merged 2 commits intobids-standard:masterfrom
yarikoptic merged 2 commits intobids-standard:masterfrom
Conversation
Contributor
yarikoptic
commented
Apr 16, 2026
yarikoptic
commented
- BIDS Specification PR: [ENH] Recommend controlled vocabulary for age Units, clarify that it can be overloaded bids-specification#2400
- BIDS Validator PR: NONE
- TODOs:
Looking at the data suggests that it is very unlikely to be months since capped at 89+ and for ukb it was not on toddlers
❯ head -n 6 genetics_ukbb/participants.tsv
participant_id age sex group genetic_id IDH BatchID VariationSetType Assembly GeneticDataType
sub-01 48 M patient 125425 yes b001 CNV hg38 SNP_intensity
sub-02 60 M control 125698 no b001 CNV hg38 SNP_intensity
sub-03 72 M patient 452589 yes b002 SNV/CNV hg19/hg38 WES/SNP_intensity
sub-04 84 F patient 325478 no b002 CNV hg38 SNP_intensity
sub-05 89+ M control 623589 yes b002 SNV/CNV hg19/hg38 WES/SNP_intensity
… years) Overall specification and testing is proposed for this in bids-standard/bids-specification#2400 === Do not change lines below === { "chain": [], "cmd": "bash -c 'sed -i -E '\"'\"'s,(Units.: .year)s,\\1,g'\"'\"' {outputs}'", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [ "*/participants.json" ], "pwd": "." } ^^^ Do not change lines above ^^^
3 tasks
Contributor
Author
|
damn -- where are the checks? should I resubmit from origin not fork? |
Contributor
|
Oh, you targeted bf-months, not |
effigies
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.