zNPCTypeAmbient: make zNPCAmbient::PhysicsFlags const - #771
Merged
SquareMan merged 1 commit intoAug 3, 2026
Merged
Conversation
xNPCBasic declares `virtual U8 PhysicsFlags() const`, but the zNPCAmbient
override dropped the qualifier, so it never overrode anything -- it introduced a
second virtual and mangled as PhysicsFlags__11zNPCAmbientFv. The retail object
only has the const form.
zNPCTypeAmbient 40/57 -> 41/57 functions
zNPCTypeAmbient is the only unit that changes; nothing regresses.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
98.02% | 98.46% | +4 |
| 📈 | .text |
65.81% | 65.91% | +7 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | zNPCAmbient::PhysicsFlags() const |
0.00% | 100.00% | +8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mangled name of this function is
PhysicsFlags__11zNPCAmbientCFv. Dropping theconstmakes it mangle asPhysicsFlags__11zNPCAmbientFvwhich does not match. Addingconstto thePhysicsFlagssignatures properly makes it match.Found via an LLM scan of the repo.