iSnd work - #769
Merged
Merged
Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
18.18% | 26.09% | +6 |
| 📈 | .text |
32.50% | 39.34% | +971 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | iSndCalcVol(xSndVoiceInfo*, vinfo*) |
0.00% | 100.00% | +148 |
| 📈 | iSndPlay(xSndVoiceInfo*) |
0.00% | 97.92% | +188 |
| ✅ | iSndDIEDIEDIE() |
0.00% | 100.00% | +200 |
| ✅ | iSndSuspend() |
0.00% | 100.00% | +148 |
| ✅ | iSndResume() |
0.00% | 100.00% | +176 |
| ✅ | iSndGetVol(unsigned int) |
0.00% | 100.00% | +112 |
main/SB/Game/zNPCTypeKingJelly
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.bss |
94.74% | 0.00% | --3781 |
| ️ |
.data |
76.13% | 54.96% | --193 |
| ️ |
.rodata |
4.23% | 3.89% | --14 |
| ️ |
.sbss |
100.00% | 0.00% | --24 |
| ️ |
.sdata2 |
74.34% | 70.39% | --12 |
| ️ |
.text |
46.53% | 41.05% | --1886 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::init_sound() |
100.00% | 0.00% | --172 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::play_sound_immediate(int, const xVec3*) |
81.48% | 0.00% | --198 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::play_sound(int, const xVec3*) |
94.12% | 4.12% | --122 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::sound_update(float) |
100.00% | 0.00% | --168 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::set_ring_segments(const xVec3&, float, float) |
39.84% | 0.00% | --256 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::updown_ring_update(lightning_ring&, float) |
100.00% | 0.00% | --152 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::expand_ring_update(lightning_ring&, float) |
100.00% | 0.00% | --164 |
| ️ |
zNPCKingJelly::zNPCKingJelly(int) |
100.00% | 0.00% | --96 |
| ️ |
@unnamed@zNPCTypeKingJelly_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) |
99.93% | 99.70% | --21 |
| ️ |
zNPCKingJelly::Damage(en_NPC_DAMAGE_TYPE, xBase*, const xVec3*) |
100.00% | 0.00% | --228 |
| ️ |
zNPCKingJelly::update_camera(float) |
100.00% | 0.00% | --76 |
| ️ |
zNPCKingJelly::set_life(int) |
100.00% | 0.00% | --232 |
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
18.18% | 26.09% | +6 |
| 📈 | .text |
32.50% | 39.34% | +971 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | iSndCalcVol(xSndVoiceInfo*, vinfo*) |
0.00% | 100.00% | +148 |
| 📈 | iSndPlay(xSndVoiceInfo*) |
0.00% | 97.92% | +188 |
| ✅ | iSndDIEDIEDIE() |
0.00% | 100.00% | +200 |
| ✅ | iSndSuspend() |
0.00% | 100.00% | +148 |
| ✅ | iSndResume() |
0.00% | 100.00% | +176 |
| ✅ | iSndGetVol(unsigned int) |
0.00% | 100.00% | +112 |
escape209
marked this pull request as draft
August 1, 2026 14:36
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
18.18% | 26.09% | +6 |
| 📈 | .text |
32.50% | 42.18% | +1375 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | iSndCalcVol(xSndVoiceInfo*, vinfo*) |
0.00% | 100.00% | +148 |
| ✅ | iSndPlay(xSndVoiceInfo*) |
0.00% | 100.00% | +192 |
| ✅ | iSndSetVol(unsigned int, float) |
0.00% | 100.00% | +400 |
| ✅ | iSndDIEDIEDIE() |
0.00% | 100.00% | +200 |
| ✅ | iSndSuspend() |
0.00% | 100.00% | +148 |
| ✅ | iSndResume() |
0.00% | 100.00% | +176 |
| ✅ | iSndGetVol(unsigned int) |
0.00% | 100.00% | +112 |
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
18.18% | 26.09% | +6 |
| 📈 | .text |
32.50% | 40.77% | +1176 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | iSndCalcVol(xSndVoiceInfo*, vinfo*) |
0.00% | 100.00% | +148 |
| ✅ | iSndPlay(xSndVoiceInfo*) |
0.00% | 100.00% | +192 |
| ✅ | iSndSetVol(unsigned int, float) |
0.00% | 100.00% | +400 |
| ✅ | iSndSuspend() |
0.00% | 100.00% | +148 |
| ✅ | iSndResume() |
0.00% | 100.00% | +176 |
| ✅ | iSndGetVol(unsigned int) |
0.00% | 100.00% | +112 |
escape209
marked this pull request as ready for review
August 2, 2026 12:10
SquareMan
reviewed
Aug 2, 2026
Comment on lines
+870
to
+871
| /* Matching | ||
| void iSndDIEDIEDIE() |
Contributor
Author
There was a problem hiding this comment.
Gonna be real I just want the 69.67% bot message in the discord 😭
Part 2 PR coming up
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata2 |
18.18% | 26.09% | +6 |
| 📈 | .text |
32.50% | 40.77% | +1176 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | iSndCalcVol(xSndVoiceInfo*, vinfo*) |
0.00% | 100.00% | +148 |
| ✅ | iSndPlay(xSndVoiceInfo*) |
0.00% | 100.00% | +192 |
| ✅ | iSndSetVol(unsigned int, float) |
0.00% | 100.00% | +400 |
| ✅ | iSndSuspend() |
0.00% | 100.00% | +148 |
| ✅ | iSndResume() |
0.00% | 100.00% | +176 |
| ✅ | iSndGetVol(unsigned int) |
0.00% | 100.00% | +112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some matches to derust.
Claude technically used for one line in iSndPlay but ended up having to matching it manually anyways.