Skip to content

set_alpha_blend 100%, abandon_slugs 100%, choose_hand 100%, NewTime 37% - #599

Merged
JoshSanch merged 2 commits into
bfbbdecomp:mainfrom
LSLees:zNPCTypeBossSB2
Sep 27, 2025
Merged

set_alpha_blend 100%, abandon_slugs 100%, choose_hand 100%, NewTime 37%#599
JoshSanch merged 2 commits into
bfbbdecomp:mainfrom
LSLees:zNPCTypeBossSB2

Conversation

@LSLees

@LSLees LSLees commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

newtime is in progress, can remove if needed

@github-actions

Copy link
Copy Markdown

🆗 ✅

+123 bytes
🆗 Bot Rating: A fair and commendable contribution

No Regressions 🎉

Progress: 7

📈 main/SB/Game/zNPCTypeBossSB2 - .text +100 bytes -> 30.32%
📈 main/SB/Game/zNPCTypeBossSB2 - .text +23 bytes -> 4.20%
📈 main/SB/Game/zNPCTypeBossSB2 - .data +2 bytes -> 74.31%
📈 main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::NewTime(xScene*, float) +36 bytes -> 11.54%
main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::choose_hand() +23 bytes -> 100.00%
main/SB/Game/zNPCTypeBossSB2 - @unnamed@zNPCTypeBossSB2_cpp@::set_alpha_blend(xModelInstance*) +31 bytes -> 100.00%
main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::abandon_slugs() +31 bytes -> 100.00%

@JoshSanch JoshSanch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we try to avoid merging heavily WIP code, since it can cause confusion for other contributors. Please take out the NewTime contribution - everything else is looking good though!

@github-actions

Copy link
Copy Markdown

🆗 ✅

+91 bytes
🆗 Bot Rating: A small contribution, every little bit helps!

No Regressions 🎉

Progress: 7

📈 main/SB/Game/zNPCTypeBossSB2 - .text +68 bytes -> 30.23%
📈 main/SB/Game/zNPCTypeBossSB2 - .text +23 bytes -> 4.20%
📈 main/SB/Game/zNPCTypeBossSB2 - .data +2 bytes -> 74.31%
📈 main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::NewTime(xScene*, float) +4 bytes -> 1.28%
main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::choose_hand() +23 bytes -> 100.00%
main/SB/Game/zNPCTypeBossSB2 - @unnamed@zNPCTypeBossSB2_cpp@::set_alpha_blend(xModelInstance*) +31 bytes -> 100.00%
main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::abandon_slugs() +31 bytes -> 100.00%

@JoshSanch JoshSanch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoshSanch
JoshSanch merged commit 16647e5 into bfbbdecomp:main Sep 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants