Skip to content

Work on zNPCType files - #597

Merged
JoshSanch merged 4 commits into
bfbbdecomp:mainfrom
bluisblu:dev
Sep 27, 2025
Merged

Work on zNPCType files#597
JoshSanch merged 4 commits into
bfbbdecomp:mainfrom
bluisblu:dev

Conversation

@bluisblu

Copy link
Copy Markdown
Contributor

Mostly updating stuff to use zNPCSndLists directly, however I did also get carried away with overhauling zNPCTypeTiki

@github-actions

Copy link
Copy Markdown

⚠️ 🔥

+1389 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 3

⚠️ main/SB/Game/zNPCTypeCommon - zNPCCommon_SceneFinish() -3 bytes -> 92.31%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitStacking(zScene*) -4 bytes -> 98.44%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Reset() -32 bytes -> 92.45%

Progress: 14

📈 main/SB/Game/zNPCTypeTiki - .text +1063 bytes -> 18.18%
📈 main/SB/Game/zNPCTypeCommon - .rodata +2 bytes -> 92.81%
📈 main/SB/Game/zNPCTypeTiki - .bss +63 bytes -> 8.08%
main/SB/Game/zNPCTypeTiki - .text +103 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeTiki - .sdata2 +99 bytes -> 57.75%
📈 main/SB/Game/zNPCTypeAmbient - .sdata2 +19 bytes -> 54.55%
📈 main/SB/Game/zNPCTypeTiki - .sbss +4 bytes -> 66.67%
📈 main/SB/Game/zNPCTypeTiki - zNPCTiki::Process(xScene*, float) +572 bytes -> 24.03%
📈 main/SB/Game/zNPCTypeTiki - zNPCTiki_InitFX(zScene*) +278 bytes -> 30.52%
📈 main/SB/Game/zNPCTypeTiki - zNPCTiki_ExplodeFX(zNPCTiki*) +4 bytes -> 0.57%
📈 main/SB/Game/zNPCTypeTiki - genericTikiRender(xEnt*) +208 bytes -> 79.10%
main/SB/Game/zNPCTypeTiki - zNPCTiki::zNPCTiki(int) +60 bytes -> 100.00%
main/SB/Game/zNPCTypeTiki - zNPCTiki::AnimPick(int, en_NPC_GOAL_SPOT, xGoal*) +44 bytes -> 100.00%
main/SB/Game/zNPCTypeTiki - tikiDeadCB(xGoal*, void*, en_trantype*, float, void*) +36 bytes -> 100.00%

@JoshSanch
JoshSanch merged commit 3c52be8 into bfbbdecomp:main Sep 27, 2025
5 checks passed
@JoshSanch

Copy link
Copy Markdown
Collaborator

Huge work

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants