Skip to content

Limit ACCTON_GFF4, ACROBOC562 and HAKRC530 to 2026.12.0 and later - #1261

Open
blckmn wants to merge 1 commit into
betaflight:masterfrom
blckmn:gate-new-targets-2026.12
Open

blckmn wants to merge 1 commit into
betaflight:masterfrom
blckmn:gate-new-targets-2026.12

Conversation

@blckmn

@blckmn blckmn commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

These three targets were added after 2026.6.2 was cut, but their DATE: 2026-05-01 marker makes cloud build offer them on every release dated after May 2026, back to 4.5.5. Those releases pin an older config that doesn't contain the target, so every such build fails with "No rule to make target".

Adding VERSION: 2026.12.0 restricts them to 2026.12.0 and later, matching the other targets added in this cycle.

Summary by CodeRabbit

  • Chores
    • Updated the listed version metadata for ACCTON GFF4, ACROBOC562, and HAKRC530 to 2026.12.0. This aligns the version information shown for these device configurations with the current release. No changes to device capabilities or behavior are included in this update.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Three target configuration headers add version 2026.12.0 to their metadata comments. No declarations change.

Changes

Target metadata updates

Layer / File(s) Summary
Add version metadata
configs/ACCT/ACCTON_GFF4/config.h, configs/ACRO/ACROBOC562/config.h, configs/HARC/HAKRC530/config.h
Each header adds version 2026.12.0 to its target metadata comment.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: haslinghuis

Merge Risk: Minimal · up to 05e87

This restricts three targets to firmware releases 2026.12.0 and later, so older releases no longer offer them and fail with "No rule to make target." There is no identified defect in the change. Whether the 2026.12.0 config pin includes these targets should be confirmed in the release process.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description states the problem: the DATE markers let cloud build offer these targets on releases that pin older configs, causing 'No rule to make target' failures. It also states the fix, adding V… Add the repository template sections or state that they do not apply. Confirm the 'Housekeeping' item: the PR must come from a custom branch, not master. Mark the checklist items as applicable or not applicable, and note that this change is…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the three targets and the 2026.12.0 version bound, which matches the change. It reflects the main change: the version marker restricts the targets to 2026.12.0 and later. The title is …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the three targets and the 2026.12.0 version bound, which matches the change. It reflects the main change: the version marker restricts the targets to 2026.12.0 and later. The title is specific and accurate.

Full details: Description check

Explanation

The description states the problem: the DATE markers let cloud build offer these targets on releases that pin older configs, causing 'No rule to make target' failures. It also states the fix, adding VERSION: 2026.12.0. The description does not follow the repository template. It has no mandatory review confirmation, hardware compliance statement, housekeeping notes, or checklist. For a config-only metadata change, these items are mostly not applicable, but the author should state that the checklist items were considered or are not applicable.

Resolution

Add the repository template sections or state that they do not apply. Confirm the 'Housekeeping' item: the PR must come from a custom branch, not master. Mark the checklist items as applicable or not applicable, and note that this change is a config-only marker update for existing targets, not a new hardware release.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c50bcde and 05e870e.

Files selected for processing: 3

  • configs/ACCT/ACCTON_GFF4/config.h
  • configs/ACRO/ACROBOC562/config.h
  • configs/HARC/HAKRC530/config.h

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants