You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Limit ACCTON_GFF4, ACROBOC562 and HAKRC530 to 2026.12.0 and later - #1261
These three targets were added after 2026.6.2 was cut, but their DATE: 2026-05-01 marker makes cloud build offer them on every release dated after May 2026, back to 4.5.5. Those releases pin an older config that doesn't contain the target, so every such build fails with "No rule to make target".
Adding VERSION: 2026.12.0 restricts them to 2026.12.0 and later, matching the other targets added in this cycle.
Summary by CodeRabbit
Chores
Updated the listed version metadata for ACCTON GFF4, ACROBOC562, and HAKRC530 to 2026.12.0. This aligns the version information shown for these device configurations with the current release. No changes to device capabilities or behavior are included in this update.
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
This restricts three targets to firmware releases 2026.12.0 and later, so older releases no longer offer them and fail with "No rule to make target." There is no identified defect in the change. Whether the 2026.12.0 config pin includes these targets should be confirmed in the release process.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Description check
The description states the problem: the DATE markers let cloud build offer these targets on releases that pin older configs, causing 'No rule to make target' failures. It also states the fix, adding V…
Add the repository template sections or state that they do not apply. Confirm the 'Housekeeping' item: the PR must come from a custom branch, not master. Mark the checklist items as applicable or not applicable, and note that this change is…
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title names the three targets and the 2026.12.0 version bound, which matches the change. It reflects the main change: the version marker restricts the targets to 2026.12.0 and later. The title is …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the three targets and the 2026.12.0 version bound, which matches the change. It reflects the main change: the version marker restricts the targets to 2026.12.0 and later. The title is specific and accurate.
Full details: Description check
Explanation
The description states the problem: the DATE markers let cloud build offer these targets on releases that pin older configs, causing 'No rule to make target' failures. It also states the fix, adding VERSION: 2026.12.0. The description does not follow the repository template. It has no mandatory review confirmation, hardware compliance statement, housekeeping notes, or checklist. For a config-only metadata change, these items are mostly not applicable, but the author should state that the checklist items were considered or are not applicable.
Resolution
Add the repository template sections or state that they do not apply. Confirm the 'Housekeeping' item: the PR must come from a custom branch, not master. Mark the checklist items as applicable or not applicable, and note that this change is a config-only marker update for existing targets, not a new hardware release.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between c50bcde and 05e870e.
Files selected for processing: 3
configs/ACCT/ACCTON_GFF4/config.h
configs/ACRO/ACROBOC562/config.h
configs/HARC/HAKRC530/config.h
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three targets were added after 2026.6.2 was cut, but their
DATE: 2026-05-01marker makes cloud build offer them on every release dated after May 2026, back to 4.5.5. Those releases pin an older config that doesn't contain the target, so every such build fails with "No rule to make target".Adding
VERSION: 2026.12.0restricts them to 2026.12.0 and later, matching the other targets added in this cycle.Summary by CodeRabbit
2026.12.0. This aligns the version information shown for these device configurations with the current release. No changes to device capabilities or behavior are included in this update.