Repository navigation
fix: FLYWOOF405 LED_STRIP_PIN PC8 - #1237
Conversation
Set LED_STRIP_PIN to PC8 (TIM8_CH3, already in TIMER_PIN_MAPPING). PA8 is USB_DETECT_PIN and has no timer map entry.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Update LED strip pin configs/FLWO/FLYWOOF405/config.h |
LED_STRIP_PIN now uses PC8 instead of PA8. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix · Severity of issue fixed: Low
Merge Risk: 
Minimal · previous review 35476
-
No concrete merge-blocking risk remains.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Linked Issues check
-
Explanation
Issue
#1236requires a valid LED strip pin for FLYWOOF405. The PR changesLED_STRIP_PINfromPA8toPC8. The reviewed config definesPC8inTIMER_PIN_MAPPINGasTIM8_CH3, whileUSB_DETECT_PINremainsPA8. This implements the issue's requestedPC8resolution. Hardware confirmation is not a coding requirement.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Full details: Description check
-
Explanation
The description explains the change and provides relevant technical evidence, but it does not follow the repository template. It omits the required review, hardware compliance, housekeeping, and checklist details.
Resolution
Add the required template sections and checklist. State the schematics review, hardware sample testing, guideline compliance, connector standards, flight testing, and issue resolution status. Confirm that the pull request uses a custom branch. Keep the explicit statement that hardware testing is pending if applicable.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: Repository: betaflight/config/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8ea9ac08-a229-4125-af21-69ce3f44dbd1
📒 Files selected for processing: 1
-
configs/FLWO/FLYWOOF405/config.h
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: Repository: betaflight/config/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
8ea9ac08-a229-4125-af21-69ce3f44dbd1
📒 Files selected for processing: 1
-
configs/FLWO/FLYWOOF405/config.h
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
-
|
@coderabbitai please review |
|
Learnings used
Action not completed
|
|
Targets cannot be arbitrarily remapped without hardware changes. This doesn't make sense. LED_STRIP now conflicts with the motors, and other pins that require timers are missing them. Why weren't those fixed? This is just a bad target with no good solutions. The conflicts are M5 and M7. SPI3 is shared between flash and OSD. Was this merged without testing? Here is the original PR that contains discussion about this: betaflight/betaflight#6526 |
|
I saw the original PR, and figured this would at least add a missing feature to an old board that few people now have to be tested, and that it was at some previous point working as intended with the definition that this PR updated to. If the feature never worked or was implemented differently and this causes more trouble, or worse yet is still in use somehow, I would definitely revert it. |
) This reverts commit fe7e7d1.
|
AI Generated comment The change was not tested on hardware, and the audit behind it was incomplete. M5: M5 (PB5) is DMA1 Stream 5. SPI3 TX (flash and OSD) can use only DMA1 Stream 5 or Stream 7, and M1 holds Stream 7. With 5 or more motors on per-channel DShot DMA (this config sets M7: PC8 ( Other gaps: PA8 is also History: in the 4.1.0 -- my sincere apologies |
AI Generated pull-request
Closes #1236.
Change
configs/FLWO/FLYWOOF405/config.h:LED_STRIP_PIN PA8toLED_STRIP_PIN PC8.Evidence
PA8is alsoUSB_DETECT_PIN(line 82) and has noTIMER_PIN_MAPPINGentry.PC8is already mapped (TIMER_PIN_MAP( 8, PC8 , 2, 0),TIM8_CH3, line 93) and no role uses it.timerAllocate()returnsNULLfor a pin that is not in the pin map, so LED strip init fails forPA8(timer_common.c#L112, light_ws2811strip_hal.c#L70).PC8,TIM8_CH3,DMA2_Stream2 LED_STRIP: https://betaflight.com/docs/wiki/boards/archive/FLYWOOF405timer C08 AF3anddma pin C08 0, with notimer A08(file).Test plan
Summary by CodeRabbit