Skip to content

fix: FLYWOOF405 LED_STRIP_PIN PC8 - #1237

Merged
haslinghuis merged 3 commits into
betaflight:masterfrom
nerdCopter:fix/FLYWOOF405-led-strip-pc8
Nov 12, 2026
Merged

haslinghuis merged 3 commits into
betaflight:masterfrom
nerdCopter:fix/FLYWOOF405-led-strip-pc8

Conversation

@nerdCopter

@nerdCopter nerdCopter commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

AI Generated pull-request

Closes #1236.

Change

configs/FLWO/FLYWOOF405/config.h: LED_STRIP_PIN PA8 to LED_STRIP_PIN PC8.

Evidence

Test plan

  • Config diff reviewed: one line.
  • Hardware: not tested on a FLYWOOF405. A board owner should confirm the LED strip pad before merge.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the FLYWOOF405 LED strip output to use the correct hardware pin, improving LED strip control on supported devices.

Set LED_STRIP_PIN to PC8 (TIM8_CH3, already in TIMER_PIN_MAPPING).
PA8 is USB_DETECT_PIN and has no timer map entry.
@nerdCopter
nerdCopter marked this pull request as ready for review October 21, 2026 15:49
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c0cd0a9 and 064c968.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The FLYWOOF405 configuration changes the LED strip output pin from PA8 to PC8.

Changes

FLYWOOF405 LED strip pin

Layer / File(s) Summary
Update LED strip pin
configs/FLWO/FLYWOOF405/config.h
LED_STRIP_PIN now uses PC8 instead of PA8.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · previous review 35476

No concrete merge-blocking risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the change and provides relevant technical evidence, but it does not follow the repository template. It omits the required review, hardware compliance, housekeeping, and check… Add the required template sections and checklist. State the schematics review, hardware sample testing, guideline compliance, connector standards, flight testing, and issue resolution status. Confirm that the pull request uses a custom bran…
Passed Passed checks: 4 passed

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the configuration fix: changing the FLYWOOF405 LED strip pin to PC8.
Linked Issues check Passed Issue #1236 requires a valid LED strip pin for FLYWOOF405. The PR changes LED_STRIP_PIN from PA8 to PC8. The reviewed config defines PC8 in TIMER_PIN_MAPPING as TIM8_CH3, while `USB_DETECT…
Out of Scope Changes check Passed The whole-PR diff contains one related change in configs/FLWO/FLYWOOF405/config.h. The change directly implements issue #1236. No unrelated source, test, or configuration changes are present.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Linked Issues check

Explanation

Issue #1236 requires a valid LED strip pin for FLYWOOF405. The PR changes LED_STRIP_PIN from PA8 to PC8. The reviewed config defines PC8 in TIMER_PIN_MAPPING as TIM8_CH3, while USB_DETECT_PIN remains PA8. This implements the issue's requested PC8 resolution. Hardware confirmation is not a coding requirement.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: Description check

Explanation

The description explains the change and provides relevant technical evidence, but it does not follow the repository template. It omits the required review, hardware compliance, housekeeping, and checklist details.

Resolution

Add the required template sections and checklist. State the schematics review, hardware sample testing, guideline compliance, connector standards, flight testing, and issue resolution status. Confirm that the pull request uses a custom branch. Keep the explicit statement that hardware testing is pending if applicable.

Finishing Touches

🧪 Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ℹ️ Recent review info

⚙️ Run configuration

  • Configuration used: Repository: betaflight/config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8ea9ac08-a229-4125-af21-69ce3f44dbd1
📥 Commits

Reviewing files that changed from the base of the PR and between 4961818 and 3547667.

📒 Files selected for processing: 1

  • configs/FLWO/FLYWOOF405/config.h

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@blckmn

blckmn commented Nov 11, 2026

Copy link
Copy Markdown
Member

@coderabbitai please review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

@blckmn I’ll review the change. The PR requests board-owner confirmation of the LED strip pad before merging.


Learnings used

Learnt from: ot0tot
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-08-27T13:41:55.162Z
Learning: Always check for duplicate defines (macros, constants, etc.) in pull requests and do not approve PRs if duplicate defines exist. This is a blocking issue that must be resolved before approval.
Learnt from: ot0tot
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the `BOARD_NAME` define in config.h files exactly matches the directory name where the config file is located. For example, if the config file is in configs/AXISFLYINGF7AIO/config.h, then the BOARD_NAME should be defined as "AXISFLYINGF7AIO". This ensures proper board identification and configuration loading in Betaflight.
Action not completed

No files to review.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@haslinghuis
haslinghuis added this pull request to the merge queue Nov 12, 2026
Merged via the queue into betaflight:master with commit fe7e7d1 Nov 12, 2026
5 checks passed
@ot0tot

ot0tot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Targets cannot be arbitrarily remapped without hardware changes.

This doesn't make sense. LED_STRIP now conflicts with the motors, and other pins that require timers are missing them. Why weren't those fixed?

This is just a bad target with no good solutions. The conflicts are M5 and M7. SPI3 is shared between flash and OSD.

Was this merged without testing?

Here is the original PR that contains discussion about this: betaflight/betaflight#6526

@VitroidFPV

Copy link
Copy Markdown
Member

I saw the original PR, and figured this would at least add a missing feature to an old board that few people now have to be tested, and that it was at some previous point working as intended with the definition that this PR updated to.

If the feature never worked or was implemented differently and this causes more trouble, or worse yet is still in use somehow, I would definitely revert it.

haslinghuis added a commit to haslinghuis/config that referenced this pull request Nov 12, 2026
@nerdCopter

nerdCopter commented Nov 12, 2026 •

Copy link
Copy Markdown
Member Author

AI Generated comment

The change was not tested on hardware, and the audit behind it was incomplete.

M5: M5 (PB5) is DMA1 Stream 5. SPI3 TX (flash and OSD) can use only DMA1 Stream 5 or Stream 7, and M1 holds Stream 7. With 5 or more motors on per-channel DShot DMA (this config sets DSHOT_DMAR_OFF), SPI3 TX gets no DMA. With the default quad mixer M5 does not claim a stream. This exists with PA8 and with PC8.

M7: PC8 (TIM8_CH3) and PC9 (TIM8_CH4) share TIM8. The LED strip sets its time base after the motors, so it would overwrite M7's DShot timing. This applies only with 7 or more motors. Read from source, not run on a board.

Other gaps: PA8 is also USB_DETECT_PIN and has no map entry. PB8 (PPM and escserial) has no map entry.

History: in the 4.1.0 KAKUTEF4 target the FLYWOOF405 build uses PC8 for the LED strip and PC9 for motor 7. The unified-target file lists LED_STRIP on A08, and the origin of that value is not established. The revert is reasonable until a board owner confirms the LED pad.


-- my sincere apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: FLYWOOF405 LED_STRIP_PIN PA8 overlaps USB_DETECT_PIN and is not in TIMER_PIN_MAPPING

5 participants