Skip to content

JHEF7DUAL: set GYRO_2_ALIGN to CW270_DEG - #1234

Merged
haslinghuis merged 3 commits into
betaflight:masterfrom
nerdCopter:fix/jhef7dual-gyro2-cw270
Nov 12, 2026
Merged

haslinghuis merged 3 commits into
betaflight:masterfrom
nerdCopter:fix/jhef7dual-gyro2-cw270

Conversation

@nerdCopter

@nerdCopter nerdCopter commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

AI Generated pull-request

Closes #1233

Summary

configs/JHEF/JHEF7DUAL/config.h: GYRO_2_ALIGN changes from CW90_DEG to CW270_DEG. GYRO_1_ALIGN stays CW90_DEG.

Evidence

  • The manufacturer download linked from the GHF722AIO-ICM product page contains FC/GHF722AIO-ICM.txt with board_name JHEF7DUAL, gyro_1_sensor_align = CW90 and gyro_2_sensor_align = CW270. It has no board alignment override. Hashes are listed in JHEF7DUAL: gyro 2 alignment should be CW270_DEG (vendor config) #1233.
  • A user with this board (ICM42688P on gyro 2) set Board Alignment Yaw 180 in the Configurator to get the correct orientation with the arrow forward.
  • CW270 is CW90 plus 180 degrees.

Limits

  • Not flight tested by the author. No board was available.
  • The manufacturer file does not state the orientation for other hardware revisions that use this target.

Checklist

  • [n/a] passed Betaflight team's schematics review: n/a, one-value correction to an existing target
  • [n/a] passed hardware samples testing: n
  • [n/a] follows guidelines: y
  • [n/a] follows connector standards: n/a
  • [n/a] flight tested: n
  • comments/issues resolved: y

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bcpw48kdq5RTmikCNZXX6u

Summary by CodeRabbit

  • Configuration
    • The JHEF7DUAL setup now uses a 270° clockwise gyro alignment instead of a 90° clockwise alignment. This changes the orientation applied to gyro readings for this configuration. Other configurations are unchanged.

The manufacturer configuration for GHF722AIO-ICM sets gyro 2 sensor
alignment to CW270. The target had CW90_DEG, 180 degrees off.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bcpw48kdq5RTmikCNZXX6u
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a950660 and cf098f6.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The gyro 2 alignment setting changes from CW90_DEG to CW270_DEG.

Changes

Gyro 2 alignment

Layer / File(s) Summary
Update gyro 2 alignment
configs/JHEF/JHEF7DUAL/config.h
The configured alignment changes from CW90_DEG to CW270_DEG.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: Minimal · previous review edb54

This change corrects the gyro 2 orientation on JHEF7DUAL to match the manufacturer configuration. It has not been flight tested, so check the orientation on hardware before relying on it.

Architecture risk: Low · up to edb54

The change affects 1 system.

Changed systems: configs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — configs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in configs/JHEF/JHEF7DUAL/config.h: The configured alignment for gyro 2 changes from CW90_DEG to CW270_DEG.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the exact configuration change: setting GYRO_2_ALIGN to CW270_DEG for JHEF7DUAL.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Finishing Touches

🧪 Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ℹ️ Recent review info

⚙️ Run configuration

  • Configuration used: Repository: betaflight/config/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5524ee3-f621-4f3d-91ef-fd673035b64a
📥 Commits

Reviewing files that changed from the base of the PR and between 0b73c1f and edb54fe.

📒 Files selected for processing: 1

  • configs/JHEF/JHEF7DUAL/config.h

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@nerdCopter nerdCopter self-assigned this Oct 19, 2026
@blckmn

blckmn commented Nov 11, 2026

Copy link
Copy Markdown
Member

@coderabbitai please review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

@blckmn I’ll review the changes.


Learnings used

Learnt from: ot0tot
Repo: betaflight/config PR: 0
File: :0-0
Timestamp: 2025-08-27T13:41:55.162Z
Learning: Always check for duplicate defines (macros, constants, etc.) in pull requests and do not approve PRs if duplicate defines exist. This is a blocking issue that must be resolved before approval.
Action not completed

No files to review.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@haslinghuis
haslinghuis added this pull request to the merge queue Nov 12, 2026
Merged via the queue into betaflight:master with commit e9a80fe Nov 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JHEF7DUAL: gyro 2 alignment should be CW270_DEG (vendor config)

4 participants