Repository navigation
FLYFISHRCF405: fix flash SPI instance and driver - #1133
Draft
nerdCopter wants to merge 4 commits into
Draft
nerdCopter wants to merge 4 commits into
nerdCopter wants to merge 4 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueWalkthroughCorrects the FLYFISHRCF405 board config: replaces the flash chip macro ChangesFLYFISHRCF405 flash chip and SPI instance fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1
Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
haslinghuis
approved these changes
Jun 18, 2026
nerdCopter
force-pushed
the
fix/FLYFISHRCF405-flash-spi
branch
from
June 18, 2026 19:00
82b8ff8 to
c1b3c13
Compare
nerdCopter
marked this pull request as draft
June 22, 2026 13:24
Member
Author
|
setting as "draft" until testing success. |
- FLASH_SPI_INSTANCE SPI2 → SPI3: PA15 (FLASH_CS_PIN) is SPI3 NSS, not SPI2. This caused flash_spi_bus to default to 2 in 2025.12.x, breaking blackbox. User workaround was manual 'set flash_spi_bus=3'. - MAX7456_SPI_INSTANCE SPI3 → SPI2: PB12 (MAX7456_SPI_CS_PIN) is SPI2 NSS. - USE_FLASH_W25Q128FV → USE_FLASH_M25P16: actual hardware is Macronix MX25L12835F (JEDEC 0xC22018), not Winbond W25Q128. Fixes betaflight#1132 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nerdCopter
force-pushed
the
fix/FLYFISHRCF405-flash-spi
branch
from
July 30, 2026 13:51
7155fa4 to
c423ca2
Compare
Member
Author
|
requesting @hakrc1 verification / resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Generated pull-request
Summary
define non-quadspi:
revert to legacy defines for SPI2 and 3
Fixes #1132
Test plan
set flash_spi_busCLI override🤖 Generated with Claude Code
Summary by CodeRabbit