Repository navigation
Reject empty response batches - #243
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty response batch now raises
InvalidResponseimmediately inparseandparse_json. Both functions previously returned an empty iterator.JSON-RPC 2.0 section 6 forbids empty response arrays. Non-empty batches keep their lazy iterator.
pytest --cov --cov-report=term-missingpasses all 123 tests on Python 3.8.20 and 3.12.3, with 100% line and branch coverage. The four new regression cases fail before the fix.ruff check .,ruff format --check .,mypyandpyrightpass.mkdocs build --strictand all 11 transport and typing example cases pass.The sdist and wheel build.
twine check --strict,check-wheel-contentsand the metadata check pass.