Repository navigation
Adjust the noise channel label and remove the top colour bars - #115
Open
benjamindehli wants to merge 4 commits into
Open
benjamindehli wants to merge 4 commits into
benjamindehli wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes to the top of the mixer. They make the header line up across every channel and give a little vertical space back.
The noise channel's header
The noise channel was marked "NZ" in a smaller font, with "noise" under it, so its header did not line up with the numbers on the other channels. It now has a short noise trace where the others have a number. The trace is as tall as the digits and as wide as a two-digit number in the same font, in the same place, so it lines up with the numbers across the strips. It turns to the accent colour on hover, like the numbers. The tooltip and the screen reader title still say "Noise channel".
The trace's height comes from the outline of the digits. JUCE's glyph bounds use the font's full line height, which made the first version about 1.5 times as tall as the numbers.
The colour bars
Every channel had a thin bar in its interval colour above its number. The channels already show their colour on the knobs, the lamps, the meters and the readouts, so the bars added little. They are gone, and the header row goes from 26 to 22 pixels, so the default window is 4 pixels shorter. A saved session that opens at its saved size gives the 4 pixels to the faders.
The pointer tool button in the gutter stands in the same row. It keeps its height of 24 pixels and stays centred on the numbers.
Docs
How it was checked
build_site.py --checkand the image size check pass too.