Skip to content

Honor Codex proxy-owned model selection - #1076

Open
kywch wants to merge 2 commits into
mainfrom
fix/codex-proxy-model-selection
Open

Honor Codex proxy-owned model selection#1076
kywch wants to merge 2 commits into
mainfrom
fix/codex-proxy-model-selection

Conversation

@kywch

@kywch kywch commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • treat exact CODEX_CONFIG.model ownership as authoritative
  • skip ACP set_model only when proxy config proves it owns requested model
  • fail closed to normal set_model behavior for missing, empty, malformed, non-object, missing-model, or mismatched config

Validation

  • 109 focused tests passed
  • Ruff, format, and git diff --check passed
  • exact-head arXiv integration condition codex-gpt54 completed at reward 1 with no provider, sandbox, or trial errors
  • full 10-condition matrix completed; sole zero reward was unrelated Gemini provider 429

Review

Maintainer or other-person review required. Author will not self-merge.


Devin Review

@kywch
kywch deployed to pypi-internal-preview August 31, 2026 01:45 — with GitHub Actions Active

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment thread src/benchflow/acp/runtime.py
@kywch
kywch deployed to pypi-internal-preview August 31, 2026 02:17 — with GitHub Actions Active
@kywch

kywch commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed the proxy-owned Codex effort finding. Requested model_reasoning_effort now enters launch config without unsupported ACP model/effort calls. Regression covers no-effort and high; all CI checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant