Skip to content

fix(cli): reject --trials > 1 without --matrix #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingran-you merged 3 commits into from
Sep 1, 2026
Merged

fix(cli): reject --trials > 1 without --matrix #1064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66994ca
fix(cli): reject --trials > 1 without --matrix instead of silently ru…
Benjamin-eecs Aug 29, 2026
0b0b472
Merge branch 'main' into fix-trials-requires-matrix
bingran-you Sep 1, 2026
b186cfb
fix(cli): explain the matrix escape hatch
bingran-you Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/benchflow/eval_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ def build_eval_plan(request: EvalCreateRequest) -> EvalPlan:
raise EvalPlanError("--matrix currently requires --tasks-dir")
if request.trials < 1:
raise EvalPlanError("--trials must be >= 1")
if request.trials > 1 and request.matrix is None:
# Only the matrix expansion consumes trials; a plain run would silently
# do one trial per task while the caller believes it ran N.
raise EvalPlanError("--trials > 1 requires --matrix")
if request.expected_tasks is not None and request.expected_tasks < 1:
raise EvalPlanError("--expected-tasks must be >= 1")
if request.canonicalize not in {"none", "one-healthy-per-task"}:
Expand Down
7 changes: 7 additions & 0 deletions tests/test_cli_arg_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ def test_build_concurrency_zero_rejected(tmp_path: Path):
assert "--build-concurrency must be >= 1" in result.stderr


def test_trials_without_matrix_rejected(tmp_path: Path):
# Only --matrix consumes trials; a plain run silently does one trial/task.
result = _invoke(tmp_path, "--sandbox", "docker", "--trials", "3")
assert result.exit_code == 1
assert "--trials > 1 requires --matrix" in result.stderr


def test_skill_mode_bogus_clean_error(tmp_path: Path):
result = _invoke(tmp_path, "--sandbox", "docker", "--skill-mode", "bogus")
assert result.exit_code == 1
Expand Down