fix(restore): accept checksum-tracked LTX - #1470
Open
corylanou wants to merge 1 commit into
Open
Conversation
PR Build Metrics
Binary Size
Dependency ChangesNo dependency changes. govulncheck OutputBuild Info
🤖 Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accept checksum-tracked LTX chains in restore compaction while preserving legacy NoChecksum behavior when the final input file uses it. Apply the same restore contract to standard replica restores and VFS hydration, with regression coverage for snapshot-plus-incremental chains.
Motivation and Context
Valid checksum-tracked LTX files pass verification, but restore previously forced the output header to NoChecksum while retaining a nonzero final post-apply checksum. Trailer validation then rejected the chain with "post-apply checksum not allowed".
This change derives the output checksum mode from the final input header, matching the trailer selected by the LTX compactor.
Fixes #1427
How Has This Been Tested?
Types of changes
Checklist