Skip to content

ft: allow specifying last_value metric type #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hauleth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ft: allow specifying last_value metric type #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/core/last_value.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ defmodule TelemetryMetricsPrometheus.Core.LastValue do

def register(metric, table_id, owner) do
handler_id = EventHandler.handler_id(metric.name, owner)
type = Keyword.get(metric.reporter_options, :prometheus_type, default_prometheus_type())

with :ok <-
:telemetry.attach(
Expand All @@ -34,7 +35,7 @@ defmodule TelemetryMetricsPrometheus.Core.LastValue do
table: table_id,
tags: metric.tags,
tag_values_fun: metric.tag_values,
type: :gauge
type: type
}
) do
{:ok, handler_id}
Expand Down Expand Up @@ -66,4 +67,7 @@ defmodule TelemetryMetricsPrometheus.Core.LastValue do
error -> EventHandler.handle_event_error(error, config)
end
end

@spec default_prometheus_type() :: :gauge
def default_prometheus_type(), do: :gauge
end