Skip to content

Fix I/O stats showing 0/0 on cgroup v2 hosts #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
void143 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix I/O stats showing 0/0 on cgroup v2 hosts #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions connector/collector/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package collector

import (
"strings"

"github.com/bcicen/ctop/models"
api "github.com/fsouza/go-dockerclient"
)
Expand Down Expand Up @@ -111,10 +113,13 @@ func (c *Docker) ReadNet(stats *api.Stats) {
func (c *Docker) ReadIO(stats *api.Stats) {
var read, write int64
for _, blk := range stats.BlkioStats.IOServiceBytesRecursive {
if blk.Op == "Read" {
// cgroup v1 reports the operation as "Read"/"Write", while cgroup v2
// reports it lowercase as "read"/"write". Match case-insensitively so
// I/O stats are populated on both (otherwise cgroup v2 hosts show 0/0).
if strings.EqualFold(blk.Op, "Read") {
read += int64(blk.Value)
}
if blk.Op == "Write" {
if strings.EqualFold(blk.Op, "Write") {
write += int64(blk.Value)
}
}
Expand Down