Dev: Fix useExhaustiveDependencies — Fire Watch components#5535
Open
conbrad wants to merge 3 commits into
Open
Dev: Fix useExhaustiveDependencies — Fire Watch components#5535conbrad wants to merge 3 commits into
conbrad wants to merge 3 commits into
Conversation
8 tasks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5535 +/- ##
==========================================
+ Coverage 66.32% 66.40% +0.08%
==========================================
Files 380 380
Lines 22543 22543
Branches 3098 3098
==========================================
+ Hits 14951 14970 +19
+ Misses 6439 6420 -19
Partials 1153 1153 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



biome-ignore lint/correctness/useExhaustiveDependenciessuppressions from Fire Watch components and fixes dep arrays properly.CreateFireWatch/FireWatchDashboard: Addeddispatchto deps. Redux dispatch is a stable reference so this is a no-op behaviourally.ReviewSubmitStep: Changed map init effect deps from[]to[fireWatch]so the summary map re-initialises if the user edits location and returns to the review step.LocationStep(most involved):handleFormUpdateconverted touseCallbackwith functionalsetFireWatch(prev => ({...}))to avoid a stale closure onfireWatch.esetMapInteractionsconverted touseCallback([map]).singleclick effect is scoped to click handling only.
handleMapClickandupdateMarkerFromInputs, which eliminates a reactive loop.Tests added
createFireWatch.test.tsx— dispatches on mount, renders all stepper labelslocationStep.test.tsx— renders lat/lon fields, formats coordinates on blur, clears geometry when inputs are emptyTest Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch
Weather Toolkit