Skip to content

SMURFI#5042

Open
brettedw wants to merge 76 commits into
mainfrom
smurfi
Open

SMURFI#5042
brettedw wants to merge 76 commits into
mainfrom
smurfi

repoint

9b8aefd
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 8, 2026 in 1m 45s

Annotations

Check warning on line 37 in web/apps/wps-web/src/features/smurfi/components/SpotSubscriptionButton.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5w3t_7Slnq5GojQBNu&open=AZ5w3t_7Slnq5GojQBNu&pullRequest=5042

Check failure on line 102 in backend/packages/wps-shared/src/wps_shared/db/models/smurfi.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "spot_request_base.id" 4 times.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgZJ2M_y02wE6k4d&open=AZ5vmgZJ2M_y02wE6k4d&pullRequest=5042

Check warning on line 92 in web/apps/wps-web/src/features/smurfi/components/admin/DistributionGroupsAdmin.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unnecessary escape character: \-.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgUb2M_y02wE6k4Y&open=AZ5vmgUb2M_y02wE6k4Y&pullRequest=5042

Check failure on line 90 in backend/packages/wps-api/src/app/smurfi/email.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 31 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5msMlWcewz58IZJIy-&open=AZ5msMlWcewz58IZJIy-&pullRequest=5042

Check warning on line 70 in backend/packages/wps-api/src/app/smurfi/nats_consumer.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use asynchronous features in this function or remove the `async` keyword.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5LzT1vl4NYYaBj0gjV&open=AZ5LzT1vl4NYYaBj0gjV&pullRequest=5042

Check warning on line 100 in web/apps/wps-web/src/features/smurfi/components/admin/DistributionGroupsAdmin.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Blob#text()` over `FileReader#readAsText(blob)`.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgUb2M_y02wE6k4b&open=AZ5vmgUb2M_y02wE6k4b&pullRequest=5042

Check failure on line 96 in web/apps/wps-web/src/features/smurfi/components/admin/DistributionGroupsAdmin.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgUb2M_y02wE6k4a&open=AZ5vmgUb2M_y02wE6k4a&pullRequest=5042

Check warning on line 5 in web/apps/wps-web/src/features/smurfi/components/requests/SpotRequestsTable.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'SpotRequestStatusColorMap'.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ6U9PcGhMHXRztp1ojU&open=AZ6U9PcGhMHXRztp1ojU&pullRequest=5042

Check failure on line 71 in backend/packages/wps-api/src/app/smurfi/preview_email.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this argument; Function "build_spot_forecast_email" expects a different type

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5msMlzcewz58IZJIy_&open=AZ5msMlzcewz58IZJIy_&pullRequest=5042

Check failure on line 506 in web/apps/wps-web/src/features/smurfi/components/requestForm/SpotRequestForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5Ll8JL3jzJuAa0EThQ&open=AZ5Ll8JL3jzJuAa0EThQ&pullRequest=5042

Check warning on line 73 in backend/packages/wps-api/src/app/smurfi/nats_consumer.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use asynchronous features in this function or remove the `async` keyword.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5LzT1vl4NYYaBj0gjW&open=AZ5LzT1vl4NYYaBj0gjW&pullRequest=5042

Check failure on line 96 in web/apps/wps-web/src/features/smurfi/components/admin/DistributionGroupsAdmin.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgUb2M_y02wE6k4Z&open=AZ5vmgUb2M_y02wE6k4Z&pullRequest=5042

Check warning on line 92 in web/apps/wps-web/src/features/smurfi/components/admin/DistributionGroupsAdmin.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unnecessary escape character: \-.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5vmgUb2M_y02wE6k4X&open=AZ5vmgUb2M_y02wE6k4X&pullRequest=5042

Check warning on line 67 in backend/packages/wps-api/src/app/smurfi/nats_consumer.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use asynchronous features in this function or remove the `async` keyword.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5LzT1vl4NYYaBj0gjU&open=AZ5LzT1vl4NYYaBj0gjU&pullRequest=5042

Check warning on line 76 in backend/packages/wps-api/src/app/smurfi/nats_consumer.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use asynchronous features in this function or remove the `async` keyword.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5LzT1vl4NYYaBj0gjX&open=AZ5LzT1vl4NYYaBj0gjX&pullRequest=5042

Check warning on line 53 in web/apps/wps-web/src/features/smurfi/components/map/SmurfiRequestsMap.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5gJq64OcYDVOXjrzzj&open=AZ5gJq64OcYDVOXjrzzj&pullRequest=5042

Check failure on line 223 in backend/packages/wps-shared/src/wps_shared/schemas/smurfi.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this assignment; "elevation" is assigned again on line 230.

See more on https://sonarcloud.io/project/issues?id=bcgov_wps&issues=AZ5Ll8Nj3jzJuAa0EThX&open=AZ5Ll8Nj3jzJuAa0EThX&pullRequest=5042