-
Notifications
You must be signed in to change notification settings - Fork 272
[WS-2208]: Integrate the “Create Activity” POST API for “Save for later” click (happy flow) #13890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LukasFrm
wants to merge
4
commits into
latest
Choose a base branch
from
WS-2208-integrate-create-activity-post-api-for-save-for-later-click-happy-flow
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7474c4d
feat: enhance SaveArticleButton and useUASButton: add title prop, imp…
LukasFrm d9b0e33
Merge branch 'latest' of https://github.com/bbc/simorgh into WS-2208-…
LukasFrm 149013d
refactor: SaveArticleButton and useUASButton to unify save action han…
LukasFrm 9b46eac
tests: remove redundant
LukasFrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,17 +4,25 @@ import styles from './index.styles'; | |
| interface SaveArticleButtonProps { | ||
| articleId: string; | ||
| service: string; | ||
| title: string; | ||
| } | ||
|
|
||
| /** A button component that allows users to save an article for later reading, | ||
| * showing the button based on user sign in status and feature toggles, | ||
| * and displaying the saved status, loading state, and handling errors from the UAS API. | ||
| * FUTURE TODO : Implement button click handler to toggle saved state */ | ||
|
|
||
| const SaveArticleButton = ({ articleId, service }: SaveArticleButtonProps) => { | ||
| const { showButton, isSaved, isLoading, error } = useUASButton({ | ||
| articleId, | ||
| service, | ||
| }); | ||
| const SaveArticleButton = ({ | ||
| articleId, | ||
| service, | ||
| title, | ||
| }: SaveArticleButtonProps) => { | ||
| const { showButton, isSaved, isLoading, error, handleSaveAction } = | ||
| useUASButton({ | ||
| articleId, | ||
| service, | ||
| title, | ||
| }); | ||
|
|
||
| if (!showButton) { | ||
| return null; | ||
|
|
@@ -43,6 +51,7 @@ const SaveArticleButton = ({ articleId, service }: SaveArticleButtonProps) => { | |
| <button | ||
| css={styles.buttonWrapper} | ||
| type="button" | ||
| onClick={() => handleSaveAction(isSaved ? 'remove' : 'save')} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor: Could we assign these strings (remove / save ) to an imported constant so they are maintained in a single location? |
||
| disabled={isLoading} | ||
| aria-label={buttonLabel} | ||
| title={buttonLabel} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.