Document the USB backup drive feature in the README - #190
Merged
Conversation
Adds the feature bullet, a supported-devices table row, a For Users walkthrough (share setup, HA network storage, format/eject), and the storage/ entry in the project structure tree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Several claims about filesystem checks, share-name uniqueness, and formatting scope conflict with the implementation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents USB drives as Home Assistant SMB backup targets.
Changes:
- Adds USB backup support to features and supported devices.
- Adds setup, credential, format, eject, and platform guidance.
- Adds the storage module to the project tree.
File summaries
| File | Description |
|---|---|
README.md |
Documents USB backup-drive functionality and usage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fsck runs before every ext4/FAT32 mount (not only dirty ones), the share suffix is serial-derived rather than guaranteed unique, and formatting targets the backup partition, not the whole drive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The Home Assistant setup instructions omit required Name and Protocol fields and inaccurately describe the username as generated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
The drawer supplies server, share, username, and password; HA's dialog also asks for a name and protocol, and only the password is generated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the shipped USB storage backup feature (PRs #174–#189):
usb_backup_<id>per-drive share name, generated credentials), armed format/eject, and thex86_64Samba gapstorage/added to the project-structure tree🤖 Generated with Claude Code