fix: validate TEST_TMPDIR path traversal in getWritableDirs#29646
Closed
Ashutosh0x wants to merge 1 commit into
Closed
fix: validate TEST_TMPDIR path traversal in getWritableDirs#29646Ashutosh0x wants to merge 1 commit into
Ashutosh0x wants to merge 1 commit into
Conversation
Add validateTestTmpdir() using PathFragment.containsUplevelReferences() to reject '../' traversal in TEST_TMPDIR before addWritablePath(). Absolute paths are allowed (legitimate via --test_tmpdir). Fixes bazelbuild#29457
6bf8e04 to
7beb07b
Compare
Contributor
Author
|
CI failures are from For reference, the identical fix pattern in PR #29631 (modifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29457
Summary
AbstractSandboxSpawnRunner.getWritableDirs()readsTEST_TMPDIRfrom the action environment and passes it directly toaddWritablePath()without validation. A malicious rule can setTEST_TMPDIRto a relative path containing../traversal sequences, causing the resolved path to escape the sandbox exec root.Root Cause
Same class of issue as #3296 (TMPDIR sanitization). The fix was partial --
TMPDIRwas sanitized butTEST_TMPDIRwas missed.TMPDIRTEST_TMPDIRFix
Added
validateTestTmpdir()usingPathFragment.containsUplevelReferences()to reject../traversal beforeaddWritablePath(). Absolute paths are allowed (legitimate via--test_tmpdir).Related