Extract proguard logic to new rules

[katre]

• Timestamp clearing now uses a small hermetic python script instead of relying on non-hermetic unzip and zip.
• Also split proguard and timestamp update actions for better caching.
• Moved fastutil proguard spec into third_party where it is used.

RELNOTES: None.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[katre]

The only test failure is an exec format error only on windows/arm64 (windows/x64 passes):

# Execution platform: //:default_host_platform
/usr/bin/bash: line 6: /c/b/4qcz3zc6/execroot/_main/external/rules_java++toolchains+remotejdk25_win_arm64/bin/jar: cannot execute binary file: Exec format error

This is pretty surprising: is there a misconfiguration with the windows/arm64 jdk?

[katre]

Hmm, adding a find call shows it really is an arm64 binary:

/usr/bin/bash: line 7: /c/b/k3n7yowv/execroot/_main/external/rules_java++toolchains+remotejdk25_win_arm64/bin/jar: cannot execute binary file: Exec format error
/c/b/k3n7yowv/execroot/_main/external/rules_java++toolchains+remotejdk25_win_arm64/bin/jar: PE32+ executable for MS Windows 6.02 (console), ARM64, 6 sections

@meteorcloudy , any ideas what's wrong here?

[katre]

I'm also tempted to rewrite this as a python script, which would probably also fix the windows issue. I'll think about it and get back to this later.

[katre]

Went ahead and used the script, and added actual rules, and re-arranged things somewhat. PTAL.

[katre]

All tests fixed, hooray.

[fmeum]

Even though this is just a rule for Bazel's internal use, it would be great if we could follow best practices and use Args instead. Folks (and AI) like to copy 😉

[katre]

Fair, I tend to write rules by copying code from https://github.com/bazelbuild/examples.

I'll look at adding an example of ctx.actions.args().

[fmeum]

Running this as a separate action means that the previous one will have non-deterministic outputs. Perhaps the two should be merged?

[katre]

In the original genrule, they were merged, and I split them up mostly to make it easier to test the timestamp-clearing script (so I didn't have to keep re-running the slower proguard step).

I'll take a look at updating the script to call proguard and combine the two actions into one.

[katre]

Combined both steps into a single python wrapper.

[katre]

I don't know enough about python runfiles on windows to fix this: is it worth looking into, or should I revert it to use separate actions?

[fmeum]

The path will likely end with .exe on Windows. In any case it's better to pass this in from location expansion of $(rlocationpath ...)