Test wimdows#29629
Draft
fmeum wants to merge 3 commits into
Draft
Conversation
fmeum
force-pushed
the
fix-rrcc-symlink
branch
2 times, most recently
from
9a2d06d to
a6ce4ac
Compare
Resolves the long-standing inconsistency in UploadManifest's handling of non-dangling absolute vs. relative symlinks, behind a new preserveAbsoluteSymlinks flag that is only set by the remote repo contents cache so existing spawn-output behavior is preserved. Without this, an rctx.symlink(Label, ...) that points into a sibling repo gets uploaded as the resolved directory it points to. Any relative symlinks inside that resolved tree are then materialized at a location where their `..` targets no longer resolve, breaking actions that read through them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None