Invalidate unresolved symlink info after deletion in the RAFS#29495
Open
fmeum wants to merge 4 commits into
Open
Invalidate unresolved symlink info after deletion in the RAFS#29495fmeum wants to merge 4 commits into
fmeum wants to merge 4 commits into
Conversation
fmeum
changed the title
fmeum
force-pushed
the
29480-fix-symlink-deletion
branch
from
051c03e to
53daf82
Compare
Collaborator
Author
|
@bazel-io fork 9.1.1 |
github-actions
Bot
added
team-Remote-Exec
Collaborator
Author
|
@bazel-io fork 8.8.0 |
tjgq
requested changes
May 23, 2026
Contributor
tjgq
left a comment
tjgq
left a comment
There was a problem hiding this comment.
Thanks for figuring this one out. Is it possible to also add a unit test in PathCanonicalizerTest?
tjgq
approved these changes
May 26, 2026
tjgq
added
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a path is deleted while using the RemoteActionFileSystem, cached symlink resolutions have to be invalidated for the original path and all intermediate resolved paths, not just the final resolved path.
Motivation
Fixes #29480
Build API Changes
No
Checklist
Release Notes
RELNOTES: None