Skip to content

fix: give build_test a descriptive rule kind #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomatotomata wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

fix: give build_test a descriptive rule kind #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rules/build_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

load("//lib:new_sets.bzl", "sets")

def _empty_test_impl(ctx):
def _skylib_build_test_impl(ctx):
is_windows = ctx.target_platform_has_constraint(ctx.attr._windows_constraint[platform_common.ConstraintValueInfo])
extension = ".bat" if is_windows else ".sh"
content = "exit 0" if is_windows else "#!/usr/bin/env bash\nexit 0"
Expand All @@ -33,8 +33,8 @@ def _empty_test_impl(ctx):
runfiles = ctx.runfiles(files = ctx.files.data),
)]

_empty_test = rule(
implementation = _empty_test_impl,
skylib_build_test = rule(
implementation = _skylib_build_test_impl,
attrs = {
"data": attr.label_list(allow_files = True),
"_windows_constraint": attr.label(default = "@platforms//os:windows"),
Expand Down Expand Up @@ -118,7 +118,7 @@ def build_test(name, targets, **kwargs):
**genrule_args
)

_empty_test(
skylib_build_test(
name = name,
data = test_data,
size = kwargs.pop("size", "small"), # Default to small for test size
Expand Down