RunfilesGroupInfo: store runfiles objects instead of depset[File]#16
Merged
Conversation
Each field in RunfilesGroupInfo now holds a full runfiles object (files, empty_filenames, symlinks, root_symlinks) rather than just a depset of files. The invariant becomes: merging all group runfiles must equal DefaultInfo.default_runfiles. Key changes: - ordered_groups returns struct(name, runfiles, metadata) - collect_groups takes ctx, auto-creates "data#<label>" groups for deps without RunfilesGroupInfo (enabling natural deduplication when the same data dep appears in multiple parts of the graph) - merge_to_limit uses runfiles.merge_all() to combine groups - Analysis test checks all four runfiles components for completeness and overlap
malt3
force-pushed
the
extend_rgi_to_contain_all_runfiles_fields
branch
from
3c88781 to
77bdead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each field in RunfilesGroupInfo now holds a full runfiles object (files, empty_filenames, symlinks, root_symlinks) rather than just a depset of files. The invariant becomes: merging all group runfiles must equal DefaultInfo.default_runfiles.
Key changes: