BUG: Use vol_model instead of vol for p type check in arch_model#834
Open
gjunjie wants to merge 2 commits intobashtage:mainfrom
Open
BUG: Use vol_model instead of vol for p type check in arch_model#834gjunjie wants to merge 2 commits intobashtage:mainfrom
gjunjie wants to merge 2 commits intobashtage:mainfrom
Conversation
The p-is-int guard compared against the raw `vol` parameter (e.g. "GARCH") using lowercase strings, so it never matched and silently allowed non-int p values through. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 99.53% 99.54% +0.01%
==========================================
Files 78 78
Lines 15817 15817
Branches 1294 1294
==========================================
+ Hits 15743 15745 +2
+ Misses 39 38 -1
+ Partials 35 34 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The p-is-int guard compared against the raw
volparameter (e.g. "GARCH") using lowercase strings, so it never matched and silently allowed non-int p values through.