Skip to content

Skip turbo:before-cache reset for editors inside turbo-permanent elements #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosa merged 1 commit into from
Apr 17, 2026
+3 −1
Merged

Skip turbo:before-cache reset for editors inside turbo-permanent elements #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/elements/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ export class LexicalEditorElement extends HTMLElement {
}

#handleTurboBeforeCache = (event) => {
this.#reset()
if (!this.closest("[data-turbo-permanent]")) {
this.#reset()
}
Comment on lines 394 to +397
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior change (skipping #reset during turbo:before-cache when the editor is within a [data-turbo-permanent] ancestor) is not covered by automated tests. Please add a Playwright browser test that (1) mounts an editor inside a data-turbo-permanent container, dispatches turbo:before-cache, and asserts the .lexxy-editor__content remains present/usable, and (2) verifies a non-permanent editor still resets on the same event.

Copilot uses AI. Check for mistakes.
}

#synchronizeWithChanges() {
Expand Down
Loading