Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,25 @@ jobs:
- name: Install JavaScript dependencies
run: yarn install --frozen-lockfile

- name: Install Playwright browsers
- name: Get Playwright version
id: playwright-version
run: echo "version=$(npx playwright --version)" >> "$GITHUB_OUTPUT"

- name: Cache Playwright browsers
id: playwright-cache
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ matrix.browser }}-${{ steps.playwright-version.outputs.version }}
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key doesn’t include runner OS/arch, but the contents of ~/.cache/ms-playwright are OS-specific browser binaries. Including something like ${{ runner.os }} (and potentially ${{ runner.arch }}) in the key helps avoid restoring incompatible binaries if the job ever runs on a different runner image or OS.

Suggested change
key: playwright-${{ matrix.browser }}-${{ steps.playwright-version.outputs.version }}
key: playwright-${{ runner.os }}-${{ runner.arch }}-${{ matrix.browser }}-${{ steps.playwright-version.outputs.version }}

Copilot uses AI. Check for mistakes.

- name: Install Playwright browser
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install --with-deps ${{ matrix.browser }}

- name: Install Playwright system deps
if: steps.playwright-cache.outputs.cache-hit == 'true'
run: npx playwright install-deps ${{ matrix.browser }}

- name: Run Playwright tests
run: yarn test:browser:${{ matrix.browser }}

Expand Down
Loading