fix: add autorestart to supervisord and healthcheck to docker-compose#1094
Open
okwn wants to merge 1 commit into
Open
fix: add autorestart to supervisord and healthcheck to docker-compose#1094okwn wants to merge 1 commit into
okwn wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autorestart=trueto both[program:base-consensus]and[program:execution]in supervisord.confexecutionandnodeservices in docker-compose.ymlProblem
If the consensus client or execution client crashes, supervisord will not restart it automatically — the node stays down until an operator manually intervenes. Additionally, docker-compose shows services as "healthy" even if the process has exited.
Solution
Two-part fix: supervisord auto-restart ensures process resilience within the container; docker healthcheck enables container-level observability via
docker compose ps.Tests
docker compose config— verify YAML is valid and healthcheck is recognizedRisk / Compatibility