Repository navigation
Feat/bidir offset table - #536
Merged
Merged
Conversation
…former Since the pipeline moved to raygeo intents, _transformer_settings() only carried machine-wide values, so BidirScanOffsetTransformer always saw an offset of 0 and the Engrave step's Bidirectional Scan Offset had no effect. Build the transformer settings per step and add the step's cut speed and bidir_x_offset_mm. Fold both into the workpiece compute token, as the offset is applied inside the compute stage and a changed value must not be served from the cache. Refs barebaric#307
On machines where the laser fires with a fixed delay, the skew between left-to-right and right-to-left raster passes grows with the speed, so one offset per step only fits one speed. - Machine.bidir_offset_table holds (speed mm/min, offset mm) rows, sorted by speed, saved with the machine profile. - interpolate_bidir_offset() interpolates linearly between rows and clamps to the first and last row; an empty table means 0. - BidirScanOffsetTransformer keeps a non-zero per-step offset and otherwise looks up the step's speed in the table, which the intent builder passes along and folds into the compute token. Refs barebaric#307
The Advanced page of the machine settings gains a "Bidirectional Scan Offset by Speed" group: one expandable row per speed with unit-aware speed and offset fields, an add button that appends a row 1000 mm/min above the fastest one (or at the maximum cut speed for an empty table) and a remove button per row. Refs barebaric#307
switch87
force-pushed
the
feat/bidir-offset-table
branch
from
October 10, 2026 21:39
2334685 to
4f626b0
Compare
Merged
Contributor
|
Thanks for this very useful PR! I added some commits on top, it looks ready to me. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
under Advanced. Engrave steps whose own Bidirectional Scan Offset is
0 use the offset for their speed, interpolated linearly between the
rows (Calibrate bidirectional scan X-offset per engrave step #307)
Fixed
the pipeline moved to raygeo intents, because the value no longer
reached the transformer; changing it now also refreshes the cached
toolpath (Calibrate bidirectional scan X-offset per engrave step #307)