-
Notifications
You must be signed in to change notification settings - Fork 100
[Master] Enforce HTTP/2 maxConcurrentStreams limit on server #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daneshk
wants to merge
14
commits into
master
Choose a base branch
from
fix/http2-max-concurrent-streams
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+209
−8
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bc9ff6b
Fix CVE-2026-47244: enforce HTTP/2 maxConcurrentStreams limit on server
daneshk fcb295d
Document HTTP/2 maxConcurrentStreams limit and system property override
daneshk 06a6e2b
Fix test to use ListenerConfiguration instead of system property for …
daneshk d2bf76b
Rework CVE-2026-47244 fix to derive maxActiveStreams from global pool…
daneshk d4c1995
Add optional http2MaxActiveStreams field to ListenerConfiguration
daneshk e543634
Fix Http2Settings API call: maxConcurrentStreams is the Netty method …
daneshk c0d4b86
Remove unused globalHttp2MaxActiveStreams field and client pool coupling
daneshk 8500a75
Fix README: server stream limit defaults to 100, tunable via http2Max…
daneshk 38f5bce
Fix ballerina/README.md: server stream limit tunable via http2MaxActi…
daneshk f4b4157
Fix method name mismatch: use setHttp2MaxConcurrentStreams in HttpUti…
daneshk 98c70d5
Remove -1 unlimited sentinel from http2MaxActiveStreams listener config
daneshk e71164a
Change http2MaxActiveStreams to int with default 100 in Ballerina, re…
daneshk d05659d
Fix Long to int cast and restore 100 default in Java fallback fields
daneshk 00d615c
Move HTTP/2 stream concurrency docs from README to spec
daneshk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,6 +134,7 @@ | |
| import static io.ballerina.stdlib.http.api.HttpConstants.ANN_CONFIG_ATTR_SSL_ENABLED_PROTOCOLS; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.CREATE_INTERCEPTORS_FUNCTION_NAME; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.ENDPOINT_CONFIG_HTTP2_INITIAL_WINDOW_SIZE; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.ENDPOINT_CONFIG_HTTP2_MAX_ACTIVE_STREAMS; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.HTTP_HEADERS; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.RESOLVED_REQUESTED_URI; | ||
| import static io.ballerina.stdlib.http.api.HttpConstants.RESPONSE_CACHE_CONTROL; | ||
|
|
@@ -1583,6 +1584,8 @@ public static ListenerConfiguration getListenerConfig(long port, BMap endpointCo | |
| listenerConfiguration.setPipeliningEnabled(true); //Pipelining is enabled all the time | ||
| listenerConfiguration.setHttp2InitialWindowSize(endpointConfig | ||
| .getIntValue(ENDPOINT_CONFIG_HTTP2_INITIAL_WINDOW_SIZE).intValue()); | ||
| listenerConfiguration.setHttp2MaxConcurrentStreams( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the pr description, it says: "Set to Where is this logic handled? |
||
| endpointConfig.getIntValue(ENDPOINT_CONFIG_HTTP2_MAX_ACTIVE_STREAMS).intValue()); | ||
|
|
||
| double minIdleTimeInStaleState = | ||
| ((BDecimal) endpointConfig.get(HttpConstants.ENDPOINT_CONFIG_IDLE_TIME_STALE_STATE)).floatValue(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.