-
Notifications
You must be signed in to change notification settings - Fork 100
Support standard HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kavix
wants to merge
1
commit into
ballerina-platform:master
Choose a base branch
from
kavix:feature/proxy-env-var-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
native/src/test/java/io/ballerina/stdlib/http/api/ProxyEnvVarTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright (c) 2026, WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | ||
| * | ||
| * WSO2 LLC. licenses this file to you under the Apache License, | ||
| * Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.ballerina.stdlib.http.api; | ||
|
|
||
| import io.ballerina.stdlib.http.transport.contract.config.ProxyServerConfiguration; | ||
| import org.testng.Assert; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| public class ProxyEnvVarTest { | ||
|
|
||
| @Test | ||
| public void testShouldBypassProxy() { | ||
| // Exact match | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("localhost", "localhost")); | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("example.com", "example.com")); | ||
|
|
||
| // Exact match case-insensitivity | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("Example.Com", "example.com")); | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("example.com", "EXAMPLE.COM")); | ||
|
|
||
| // Wildcard | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("example.com", "*")); | ||
|
|
||
| // Suffix match | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("sub.example.com", "example.com")); | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("sub.example.com", ".example.com")); | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("example.com", ".example.com")); | ||
|
|
||
| // No match | ||
| Assert.assertFalse(HttpUtil.shouldBypassProxy("another-example.com", "example.com")); | ||
| Assert.assertFalse(HttpUtil.shouldBypassProxy("example.org", "example.com")); | ||
|
|
||
| // List match | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("localhost", "example.com, localhost, google.com")); | ||
| Assert.assertTrue(HttpUtil.shouldBypassProxy("sub.example.com", "example.com, localhost")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testParseProxyUrl() { | ||
| // Without scheme | ||
| ProxyServerConfiguration config1 = HttpUtil.parseProxyUrl("proxy.example.com:8080"); | ||
| Assert.assertEquals(config1.getProxyHost(), "proxy.example.com"); | ||
| Assert.assertEquals(config1.getProxyPort(), 8080); | ||
| Assert.assertNull(config1.getProxyUsername()); | ||
| Assert.assertNull(config1.getProxyPassword()); | ||
|
|
||
| // With scheme (http) | ||
| ProxyServerConfiguration config2 = HttpUtil.parseProxyUrl("http://proxy.example.com:8080"); | ||
| Assert.assertEquals(config2.getProxyHost(), "proxy.example.com"); | ||
| Assert.assertEquals(config2.getProxyPort(), 8080); | ||
|
|
||
| // With credentials | ||
| ProxyServerConfiguration config3 = HttpUtil.parseProxyUrl("http://user:pass@proxy.example.com:8080"); | ||
| Assert.assertEquals(config3.getProxyHost(), "proxy.example.com"); | ||
| Assert.assertEquals(config3.getProxyPort(), 8080); | ||
| Assert.assertEquals(config3.getProxyUsername(), "user"); | ||
| Assert.assertEquals(config3.getProxyPassword(), "pass"); | ||
|
|
||
| // Without port | ||
| ProxyServerConfiguration config4 = HttpUtil.parseProxyUrl("http://proxy.example.com"); | ||
| Assert.assertEquals(config4.getProxyHost(), "proxy.example.com"); | ||
| Assert.assertEquals(config4.getProxyPort(), 80); | ||
|
|
||
| // HTTPS scheme without port | ||
| ProxyServerConfiguration config5 = HttpUtil.parseProxyUrl("https://proxy.example.com"); | ||
| Assert.assertEquals(config5.getProxyHost(), "proxy.example.com"); | ||
| Assert.assertEquals(config5.getProxyPort(), 443); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.