Fix stdin regression with docker - #274
Closed
phaseOne wants to merge 1 commit into
Closed
Conversation
Speculating that this broke with Docker Desktop 4.10.0 based on moby/moby#43799
Contributor
|
Hello, I recreated your PR here as it needs a Change-type to be pass our CI process. Thanks for the fix, helps a lot !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine running Docker Desktop for ARM Mac 4.11.1 (84025), running
balena preloadgets stuck atReading image information.The cause is that the container never receives data on
stdin, sopreload.pyremains idle.Speculation suggests that this broke with Docker Desktop 4.10.0 based on moby/moby#43799. I've also submitted an upstream PR to apocas/docker-modem#148 to make the change in this PR the default, but I'm submitting this PR in hopes to resolve the issue for balena users faster.
For future refactors, I suggest adding additional logging in
preload.pythat's more helpful than what I've contributed in this PR.