Skip to content

Fix stdin regression with docker - #274

Closed
phaseOne wants to merge 1 commit into
balena-io-modules:masterfrom
phaseOne:patch-1
Closed

Fix stdin regression with docker#274
phaseOne wants to merge 1 commit into
balena-io-modules:masterfrom
phaseOne:patch-1

Conversation

@phaseOne

@phaseOne phaseOne commented Sep 9, 2022

Copy link
Copy Markdown

On my machine running Docker Desktop for ARM Mac 4.11.1 (84025), running balena preload gets stuck at Reading image information.

% balena preload …
| Checking that the image is a writable file
| Finding a free tcp port
| Checking if the image is an edison zip archive
/ Creating preloader container
| Starting preloader container
- Fetching application USER/APP
- Reading image information

The cause is that the container never receives data on stdin, so preload.py remains idle.

Speculation suggests that this broke with Docker Desktop 4.10.0 based on moby/moby#43799. I've also submitted an upstream PR to apocas/docker-modem#148 to make the change in this PR the default, but I'm submitting this PR in hopes to resolve the issue for balena users faster.

For future refactors, I suggest adding additional logging in preload.py that's more helpful than what I've contributed in this PR.

Speculating that this broke with Docker Desktop 4.10.0 based on moby/moby#43799
@aethernet

Copy link
Copy Markdown
Contributor

Hello,

I recreated your PR here as it needs a Change-type to be pass our CI process.

Thanks for the fix, helps a lot !!

@aethernet aethernet closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants