Update dependency golangci/golangci-lint to v2.10.1

Makefile

@@ -10,7 +10,7 @@ include ./version.mk
 
 # Helper software versions
 CONTROLLER_TOOLS_VERSION := v0.19.0
-GOLANGCI_VERSION := v2.8.0
+GOLANGCI_VERSION := v2.10.1
 HELM_VERSION := v3.20.0
 KUBECTL_VERSION := v1.35.1
 KUSTOMIZE_VERSION := v5.8.1

diskrsync-tcp/main.go

@@ -43,7 +43,7 @@ type options struct {
 }
 
 func usage() {
-	_, _ = fmt.Fprintf(os.Stderr, "Usage: %s [devicepath] [flags]\n", os.Args[0])
+	_, _ = fmt.Fprintf(os.Stderr, "Usage: %s [devicepath] [flags]\n", os.Args[0]) // nolint:gosec
 	flag.PrintDefaults()
 	os.Exit(2)
 }
@@ -119,6 +119,7 @@ func createControlFile(fileName string) error {
 }
 
 func connectToTarget(sourceFile, targetAddress string, port int, opts *options, logger logr.Logger) error {
+	// nolint:gosec
 	f, err := os.Open(sourceFile)
 	if err != nil {
 		return err
@@ -176,6 +177,7 @@ func startServer(targetFile string, port int, opts *options, logger logr.Logger)
 	var w spgz.SparseFile
 	useReadBuffer := false
 
+	// nolint:gosec
 	f, err := os.OpenFile(targetFile, os.O_RDWR|os.O_CREATE, 0666)
 	if err != nil {
 		return err

internal/controller/mover/rclone/rclone_test.go

@@ -1219,6 +1219,7 @@ var _ = Describe("Rclone as a source", func() {
 							{
 								MountPath: "addl-secret",
 								VolumeSource: volsyncv1alpha1.MoverVolumeSource{
+									// nolint:gosec
 									Secret: &corev1.SecretVolumeSource{
 										SecretName: "rclone-extra-secret",
 									},

internal/controller/mover/syncthing/api/connection_utils.go

@@ -75,7 +75,7 @@ func (api *syncthingAPIConnection) jsonRequest(
 		req.Header.Set(key, value)
 	}
 
-	resp, err := api.apiConfig.Client.Do(req)
+	resp, err := api.apiConfig.Client.Do(req) // nolint:gosec
 	if err != nil {
 		return nil, err
 	}

internal/controller/mover/syncthing/api/types.go

@@ -83,7 +83,7 @@ type SystemConnections struct {
 // nolint:revive
 type APIConfig struct {
 	APIURL string `json:"apiURL"`
-	APIKey string `json:"apiKey"`
+	APIKey string `json:"apiKey"` // nolint:gosec
 	// don't marshal this field
 	TLSConfig *tls.Config
 	Client    *http.Client

internal/controller/mover/syncthing/syncthing_test.go

@@ -606,6 +606,7 @@ var _ = Describe("When an RS specifies Syncthing", func() {
 			When("Syncthing server does not exist", func() {
 
 				JustBeforeEach(func() {
+					// nolint:gosec
 					mover.apiConfig = api.APIConfig{
 						APIURL: "https://my-fake-api-address-123",
 						APIKey: "not-a-real-api-key",