chore: fixed broken test (timezones 🤷) - #187
Open
fearphage wants to merge 1 commit into
Open
Conversation
Signed-off-by: Phred <fearphage@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails consistently locally. There seems to be a logic issue with respect to time zones.
Details
The test expects to run on midnight Tuesday UTC (
2022-06-28) using a fake timer. However it was actually generating a date that was relative to the local time. So for me, midnight UTC is 7pm CDT on the previous day (06-27which is a Monday) so the test would fail. I patched this by always adjusting the time based on the timezone offset.Verification
From a very basic set of local testing, it seems to pass consistently (where the
mainbranch fails):