Repository navigation
Conversation
With cooldown reset, a player could stack several Mechanical Dragonlings by using the trinket in a duel and forfeiting. When the duel reset leaves a spell ready (duel start, or duel end after cooldowns are restored), the creatures that spell summons directly and the player still has nearby now despawn. The player's pet (Player::GetPet) is kept. Closes azerothcore#19
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Self-review — fix/19-duel-reset-dragonling-summons → masterOutcome 5 findings — 5 fixed — round cap reached (3 rounds) Fixes not re-reviewed: PR "How to Test the Changes" steps 1, 2, 4, 5 and 6, reworded after round 3 (findings 4, 5) Reviewed By Claude Code (Claude Agent SDK), Opus 5.5 ( Build core + module, Linters module CI greps (trailing blank, tab, In-game testing author tested Mechanical Dragonling (item 4396) at duel end ( Review details (3 rounds)Intent Fix mod-duel-reset#19: the module's cooldown reset at duel start and at duel end lets a player stack Project rules Diff Metadata The module is its own git repo ( Round 1 —
|
|
CC @Helias |
Changes Proposed:
/dueland/forfeit.ResetSpellCooldownsnow returns the spells it reset, and the newRemoveSpellSummonsinsrc/DuelReset.cppdoes the despawn. Only creatures from the spell's ownSPELL_EFFECT_SUMMONeffects count, only the player's own summons are touched, and the player's pet (Player::GetPet) is kept.Issues Addressed:
SOURCE:
Item 4396 casts spell 4073, which summons creature 2678 (Spell.dbc).
Tests Performed:
-DMODULES=static, no warnings in the module./forfeit, it despawns at duel end. Used before a duel, it despawns when the duel starts. Using it again summons just one.How to Test the Changes:
DuelReset.Cooldowns = 1and use two characters in an area allowed byDuelReset.Zones/DuelReset.Areas. The one using the trinket needs level 30+ and Engineering 200 (.setskill 202 200)..additem 4396), equip it, start a duel and use it./forfeit. The dragonling despawns and the trinket is ready./forfeit, that one stays and the trinket goes back to the cooldown it had before the duel, since the module puts that cooldown back.DuelReset.Cooldowns = 0. Nothing despawns.