Repository navigation
fix(DuelReset): Fill druid mana in feral forms - #38
Conversation
ResetAllPowers only fills the active power type, so a druid in Cat, Bear or Dire Bear Form started the duel without full mana. Fill the druid's mana after the reset; the value saved before the duel is still restored when it ends. Closes azerothcore#30
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Self-review — fix/druid-feral-mana-reset → masterOutcome 9 findings — 9 fixed — final round's single finding fixed Fixes not re-reviewed finding 9 (PR description, How to Test steps 3–4: exact-value formula removed) Reviewed By Claude Code (Claude Agent SDK), Opus 5.5 ( Tested in-game by the author druid in Cat Form and in Bear/Dire Bear Form gets full mana at duel start; Lint Review details (5 rounds)Intent With Project rules Diff Metadata Procedural: rounds 4 and 5 ran beyond the cap of 3 at the author's request. No reviewer run left files in the Round 1 —
|
|
CC @Helias |
Changes Proposed:
DuelReset.HealthMana = 1, a druid who starts a duel in Cat, Bear or Dire Bear Form now gets full mana, like a druid in caster form already did.ResetAllPowers()only fills the active power type. In those forms that's energy or rage, so the mana stayed where it was. After the reset, the druid's mana is now set to max. In forms that already use mana it's already full at that point, so the extraSetPowerdoes nothing.AI-assisted Pull Requests
Important
Using AI tools to prepare pull requests is allowed, but it must be disclosed and it must follow our AC guidelines for AI Agentic Engineering (link below).
You are expected to fully understand the changes you submit and to be able to explain and justify them when maintainers ask.
Issues Addressed:
SOURCE:
Player::ResetAllPowers()only refills a power whenHasActivePowerType(power)is true, and shapeshifting into Cat/Bear/Dire Bear switches the active power to energy/rage.Tests Performed:
How to Test the Changes:
DuelReset.HealthMana = 1. With the defaultDuelReset.Areas = "12;14;809"the module matches the exact subarea, so the reset only runs where the minimap shows exactly "Elwynn Forest", "Durotar" or "Gates of Ironforge" (not in subareas like Goldshire, Crystal Lake, Razor Hill or Valley of Trials). To test anywhere, setDuelReset.Zones = ""instead.