Repository navigation
ci: use the shared codestyle workflow #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,10 @@ | ||
| name: Codestyle Checks | ||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| branches: | ||
| - 'master' | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| check-codestyle: | ||
| strategy: | ||
| fail-fast: false | ||
|
|
||
| runs-on: ubuntu-latest | ||
| name: Check Codestyling | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Check Codestyling | ||
| run: source ./apps/ci/ci-codestyle.sh | ||
| codestyle: | ||
| uses: azerothcore/reusable-workflows/.github/workflows/codestyle_modules.yml@main | ||
Empty file.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win
Reachability: External
Exploitability: Difficult
CWE: CWE-829 — Inclusion of Functionality from Untrusted Control Sphere
Pin the reusable workflow to an immutable commit SHA.
@mainresolves when each run starts. An upstream branch update can replace code that executes in the caller job context and can access itsGITHUB_TOKEN. Pin this reference to the full commit SHA for the approved reusable-workflow revision.Based on learnings: mutable GitHub Actions refs must use immutable commit SHAs.
🧰 Tools
🪛 zizmor (1.30.0)
[warning] 9-11: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents
🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: azerothcore/mod-duel-reset
Length of output: 911
🌐 Web query:
GitHub Docs reusable workflows GITHUB_TOKEN permissions caller called workflow permissions can only be maintained or reduced💡 Result:
Inspection citation: inspection_2d5dd65394f842b05f30e25937ac764e
<source_evidence>
Citations:
🏁 Script executed:
Repository: azerothcore/mod-duel-reset
Length of output: 974
🌐 Web query:
site:github.com/azerothcore/reusable-workflows ".github/workflows/codestyle_modules.yml" permissions contents checkout grep💡 Result:
Inspection citation: inspection_0e45a6c7d01900a1b2c50c967b8abab2
<source_evidence>
Citations:
Security Misconfiguration
Reachability: External
Exploitability: Difficult
CWE: CWE-250
Declare read-only token permissions for this caller.
codestyle_modules.ymlhas nopermissionsdeclaration. Its checkout steps and local grep-based script need only repository contents. Without caller permissions, the reusable workflow receives the caller's defaultGITHUB_TOKENpermissions.🧰 Tools
🪛 zizmor (1.30.0)
[warning] 9-11: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents