Repository navigation
feat: Translate player strings via module_string - #32
Conversation
Move the 14 chat messages and 20 gossip options of the replay NPC from hardcoded English text to module_string, so each player sees them in the client locale. The English text is unchanged. Add translations for the 8 locales of module_string_locale in a new ArenaReplayStrings.sql, kept apart from ArenaReplayWorld.sql so a translation fix does not reapply the NPC data.
Self-review — feat/module-string-translations → mainOutcome 4 findings — 1 fixed, 1 deferred, 2 dismissed — no further round needed Caveat fixes not re-reviewed: finding 3 (PR title and description with Caveat not tested in-game yet (author) Reviewed By Claude Code (desktop app, Claude Agent SDK), Claude Opus 5.5 ( Verification C++ codestyle linter: only the 8 findings already at the merge base (shifted +45 lines), none new; SQL linter rules: pass; SQL vs enum script: 34 ids match, English byte-identical, 272 locale rows with matching Review details (1 round)Intent Resolve #5: serve the module's player-facing chat messages and NPC gossip options from Project rules Diff Metadata Target is Reviewer wrote nothing into either repository (file lists compared against a pre-review baseline). Round 1 —
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
CC @Helias |
|
I'll have a look |
What and why
Closes #5
The chat messages and the gossip options of the replay NPC (98500) were hardcoded English in
src/ArenaReplay.cpp. They now come frommodule_string/module_string_locale, so each player sees them in their client's locale. The English text is unchanged.Decisions worth knowing
data/sql/db-world/ArenaReplayStrings.sql, apart fromArenaReplayWorld.sql. The updater reapplies a module file whenever its hash changes, so fixing a translation won't reapply the NPC data.Updates.EnableDatabasesthe core does it on startup. Servers that apply module SQL by hand need to import it before running this, since a missingmodule_stringrow makes the core'sGetModuleStringreturn an invalid pointer."vs"in the replay list stays as is, it reads the same in every locale. So does"Battleground": it's stored as the team name incharacter_arena_replays, it isn't UI text.Translations
koKR, frFR, deDE, zhCN, zhTW, esES, esMX and ruRU are included. They weren't reviewed by native speakers, so corrections are welcome. esES and esMX are the same.
Known gaps
src/ArenaReplay.cpp. Whichever merges last should move the 2 strings fix: let players watch their own match replays #31 adds tomodule_stringtoo.Testing
Not tested in-game yet.
AI-assisted: Claude Code (Claude Opus 5.5).
Summary by CodeRabbit