Skip to content

chore(deps): update dependency @siemens/ngx-datatable to v26 - abandoned #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore(deps): update dependency @siemens/ngx-datatable to v26 - abandoned #3815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0358cf
chore(deps): update dependency @siemens/ngx-datatable to v26
renovate[bot] Jun 22, 2026
245c33e
fix: adapt to @siemens/ngx-datatable v26 API changes
Helias Jun 22, 2026
09199b6
Merge branch 'master' into renovate/siemens-ngx-datatable-26.x
Helias Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/keira/src/app/scss/imports.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
@import '../../../../../node_modules/@fortawesome/fontawesome-free/scss/regular';
@import '../../../../../node_modules/@fortawesome/fontawesome-free/scss/brands';
@import '../../../../../node_modules/highlight.js/styles/github.css';
@import '../../../../../node_modules/@siemens/ngx-datatable/index.css';
@import '../../../../../node_modules/@siemens/ngx-datatable/assets/icons.css';
@import '../../../../../node_modules/ngx-ui-switch/ui-switch.component';
@import '../../../../../node_modules/ngx-toastr/toastr.css';
Expand Down
5 changes: 3 additions & 2 deletions libs/shared/base-abstract-classes/src/components/editors/select-complex-key.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { ComplexKeyHandlerService } from '../../service/handlers/complex-key.handler.service';
import { DataTablePageEvent, TableRow, WIKI_BASE_URL } from '@keira/shared/constants';
import { TableRow, WIKI_BASE_URL } from '@keira/shared/constants';
import { DTCFG } from '@keira/shared/config';
import { ChangeDetectorRef, inject } from '@angular/core';
import { PageEvent } from '@siemens/ngx-datatable';
import { SearchService } from '../../service/select/search.service';

/* istanbul ignore next */ // TODO: fix coverage
Expand All @@ -26,7 +27,7 @@ export abstract class SelectComplexKeyComponent<T extends TableRow> {
this.selectService.onSearch(this.changeDetectorRef);
}

onPage(event: DataTablePageEvent): void {
onPage(event: PageEvent): void {
this.selectService.pageOffset = event.offset;
}
}
5 changes: 3 additions & 2 deletions libs/shared/base-abstract-classes/src/components/editors/select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* istanbul ignore file */ // TODO: fix coverage
import { ChangeDetectorRef, inject } from '@angular/core';
import { DataTablePageEvent, TableRow } from '@keira/shared/constants';
import { TableRow } from '@keira/shared/constants';
import { PageEvent } from '@siemens/ngx-datatable';
import { SelectService } from '../../service/select/select.service';
import { MysqlQueryService } from '@keira/shared/db-layer';
import { HandlerService } from '../../service/handlers/handler.service';
Expand All @@ -22,7 +23,7 @@ export abstract class SelectComponent<T extends TableRow> {
this.selectService.onSearch(this.changeDetectorRef);
}

onPage(event: DataTablePageEvent): void {
onPage(event: PageEvent): void {
this.selectService.pageOffset = event.offset;
}
}
8 changes: 0 additions & 8 deletions libs/shared/constants/src/types/general.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,3 @@ export interface FieldDefinition {
name: string;
tooltip: string;
}

// Defines a type for the ngx datatable page event
export interface DataTablePageEvent {
count: number; // Total number of rows in the table
pageSize: number; // Number of rows per page (same as the 'limit' property)
limit: number; // Maximum rows displayed per page (also same as 'pageSize')
offset: number; // Current page index (0-based)
}
4 changes: 2 additions & 2 deletions ...ed/selectors/src/selectors/single-value-selector/single-value-selector-modal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class SingleValueSelectorModalComponent extends BaseSelectorModalComponen
}
}

onSelect({ selected }: { selected: { value: string | number }[] }) {
this.value = selected[0].value;
onSelect({ selected }: { selected: Option[] }) {
this.value = selected[0].value as string | number;
}
}
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"@nx/workspace": "23.0.0",
"@playwright/test": "1.61.0",
"@schematics/angular": "22.0.3",
"@siemens/ngx-datatable": "22.4.2",
"@siemens/ngx-datatable": "26.2.1",
"@swc-node/register": "1.11.1",
"@swc/core": "1.15.41",
"@swc/helpers": "0.5.23",
Expand Down
Loading