Update in crt_v2.sh, new docs and cleanup#4
Open
TheArqsz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @az7rb
First and foremost, thank you for creating crt.sh! I've been using it in a few of my automated bounty environments, and it has proven to be useful. While the script itself might appear simple, it does an amazing job of consolidating and cleaning up the communication with crt.sh.
During my usage, I noticed a few minor areas where the script could be updated and cleaned up for improved readability and maintainability. I've gone through and made some adjustments.
I've also added comprehensive docstrings to all functions and the tool itself. My aim with this is to make the codebase more understandable and easier for future contributors to navigate and enhance. I actually used my own
bashdogtool for this, which you can find here.I hope these changes are beneficial for the project. Please let me know your thoughts, and I'm happy to make any further adjustments.