nat46-core: Eliminate unused variable compilation warning - #75
Conversation
The variable `icmph` is declared as `struct icmphdr *icmph;` but is never initialized or used (except within the compile-time `sizeof(*icmph)` operator).
|
I’d probably keep the {} just for the aesthetic consistency with the other blocks - what do you think about it ? (not a hard precondition, and you probably spend more time looking at this than me - so, I am happy to merge it as is if you prefer it ! :) |
|
Technically this is my bad: I should have this resolved in the previous PR but not until coming across a cross compiling. |
ayourtch
left a comment
ayourtch
left a comment
There was a problem hiding this comment.
No prob, thanks a lot for looking at it ! (by the way - I wonder if we should start making the CI (now that there is some semblance of CI) a bit stricter ? so that it could catch the things like this beforehand ? I deliberately wanted to make it non-intrusive, but stuff like "unused variables" it can give some help with.
2 participants
The variable
icmphis declared asstruct icmphdr *icmph;but is never initialized or used (except within the compile-timesizeof(*icmph)operator).