aya-ebpf-macros: emit uprobe.multi sections#1548
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Allow #[uprobe] and #[uretprobe] to take a multi argument and emit the uprobe.multi and uretprobe.multi ELF section names in object files.
swananan
force-pushed
the
feat/uprobe-ebpf-multi
branch
from
51ced8e to
8dd77ed
Compare
tamird
left a comment
tamird
left a comment
There was a problem hiding this comment.
@tamird reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on swananan).
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR extends aya-ebpf-macros uprobe/uretprobe proc-macros to support a multi attribute and emit libbpf-compatible .multi section names (including correct ordering with .s for sleepable probes).
Changes:
- Add
multiparsing to#[uprobe]/#[uretprobe]and emituprobe.multi*/uretprobe.multi*ELF section name prefixes. - Ensure
.multiis emitted before.s(sleepable) in the section name prefix. - Refactor existing unit tests into parameterized
test-casecoverage for multiple section-name combinations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
aya-ebpf-macros/src/uprobe.rs |
Adds multi flag and updates section-name construction + expands unit tests via test-case. |
aya-ebpf-macros/Cargo.toml |
Adds test-case as a dev-dependency for the new parameterized tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dd77ed8bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Allow #[uprobe] and #[uretprobe] to take a multi argument and emit the uprobe.multi and uretprobe.multi ELF section names in object files.
Split out from #1417 for easier review.
Added/updated tests?
We strongly encourage you to add a test for your changes.
Checklist
cargo +nightly fmt.You can find failing lints with
cargo xtask clippy.cargo test.cargo xtask public-api --bless.(Optional) What GIF best describes this PR or how it makes you feel?
This change is