feat: Added bounds check for SkBuff::load_bytes and relevant integration test.#1539
feat: Added bounds check for SkBuff::load_bytes and relevant integration test.#1539benaryorg wants to merge 2 commits into
SkBuff::load_bytes and relevant integration test.#1539Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
6917c9e to
9d6bf0f
Compare
|
Apologies for that.… turns out having two shells on two different machines in the same repo is not the best idea. Since I usually develop in sandboxed environments (forgive me, but I really don't trust other people's build scripts to not write where they shouldn't) a few things on that end failed. |
|
Looks like this has merge conflicts. |
Adds a test program `read_one` that triggers a verifier error when attempting to read one byte from the SkBuffContext. Signed-off-by: benaryorg <binary@benary.org>
This resolves the verifier error triggered by the test case added in the previous commit
5ce08d6 to
561633a
Compare
|
Unfortunate timing with 8edfe49 getting merged in-between. Should be fixed now. |
This is a reboot of #1218, with some minor commit juggling (i.e. moving changes from one commit to the other to make them a little more atomic).
Added/updated tests?
We strongly encourage you to add a test for your changes.
have not been included
Checklist
cargo +nightly fmt.You can find failing lints with
cargo xtask clippy.cargo test.cargo xtask public-api --bless.(the last two err out on my machine due to problems in the development environment, not the changes themselves)
Unit test failures:
maps::tests::test_create_perf_event_arraybecause/sys/devices/system/cpu/possibleis not available in the sandbox I run tests inmaps::hash_map::per_cpu_hash_map::tests::test_get_not_found: probably the same thing:(Optional) What GIF best describes this PR or how it makes you feel?
Me trying to run the tests without setting up the full development environment.
Also: me running the tests against the wrong branch.
This change is