aya-ebpf: return &CStr from _str helpers#1531
Draft
tamird wants to merge 1 commit into
Draft
Conversation
Replace deprecated helpers with non-deprecated ones and change to return `CStr` since the underlying helpers are documented as always nul-terminating the destination buffer. TODO: the code (correctly) documents an inconsistency in the kernel where it returns len=0 when the copied string is empty; that is fine when the destination is non-empty but when the destination *is* empty it's not possible to return a CStr backed by that buffer. So what do?
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated helpers with non-deprecated ones and change to return
CStrsince the underlying helpers are documented as alwaysnul-terminating the destination buffer.
TODO: the code (correctly) documents an inconsistency in the kernel
where it returns len=0 when the copied string is empty; that is fine
when the destination is non-empty but when the destination is empty
it's not possible to return a CStr backed by that buffer. So what do?
This change is