Skip to content

fio: prevent OOM by not allocating buffer for TRIM range #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axboe merged 1 commit into from
Apr 22, 2026
+12 −1
Merged

fio: prevent OOM by not allocating buffer for TRIM range #2069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,10 @@ int init_io_u_buffers(struct thread_data *td)
char *p;

max_units = td->o.iodepth;
max_bs = td_max_bs(td);
if (td->trim_verify && td->o.trim_zero)
max_bs = td_max_bs(td);
else
max_bs = td_max_rw_bs(td);
min_write = td->o.min_bs[DDIR_WRITE];
td->orig_buffer_size = (unsigned long long) max_bs
* (unsigned long long) max_units;
Expand Down
8 changes: 8 additions & 0 deletions fio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,14 @@ static inline bool should_check_rate(struct thread_data *td)
return (td->flags & TD_F_CHECK_RATE) != 0;
}

/*
* This function considers only read and write block sizes.
*/
static inline unsigned long long td_max_rw_bs(struct thread_data *td)
{
return max(td->o.max_bs[DDIR_READ], td->o.max_bs[DDIR_WRITE]);
}

static inline unsigned long long td_max_bs(struct thread_data *td)
{
unsigned long long max_bs;
Expand Down