fix: report specific missing security group IDs in EC2NodeClass status#9036
Open
fix: report specific missing security group IDs in EC2NodeClass status#9036
Conversation
When securityGroupSelectorTerms specifies security group IDs that do not exist in AWS, the controller previously set a generic 'SecurityGroupSelector did not match any SecurityGroups' condition. This change compares the requested IDs against the IDs returned by the EC2 DescribeSecurityGroups API and explicitly reports which IDs were not found, e.g.: 'Security groups do not exist: [sg-abc123, TBD-testing]' This makes it significantly easier to diagnose misconfigured or non-existent security group IDs in an EC2NodeClass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When securityGroupSelectorTerms specifies security group IDs that do not exist in AWS, the controller previously set a generic 'SecurityGroupSelector did not match any SecurityGroups' condition.
This change compares the requested IDs against the IDs returned by the EC2 DescribeSecurityGroups API and explicitly reports which IDs were not found, e.g.:
'Security groups do not exist: [sg-abc123, TBD-testing]'
This makes it significantly easier to diagnose misconfigured or non-existent security group IDs in an EC2NodeClass.
Fixes #N/A #9035
Description
Observed Behavior: The EC2NodeClass supports including security groups that don't exist. Karpenter creates the EC2NodeClass even when a security group doesn't exist, without validation
Expected Behavior: When creating an EC2NodeClass, Karpenter should validate that all specified security groups actually exist before proceeding with the creation. Ideally it should just use security group IDs and not allow anything else.
Reproduction Steps (Please include YAML):
EC2NodeClass is created successfully even with non-existent security groups.
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.