Conversation
huanshenyi
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
HI @sundargthb ,could you please take a look at this PR when you have a chance? |
|
FWIW - if this feature were already included in the Typescript SDK, it would have made AgentCore a contender for my platform. |
* chore: remove examples directory Remove all example files and update package.json scripts to exclude examples from linting and formatting. * chore: enable linting for test directories and fix all lint errors - Remove __tests__ from ESLint ignores to enable linting on test files - Add tests_integ to lint and format scripts in package.json - Exclude test files from main src ESLint config to avoid tsconfig errors - Add missing globals for test files (setTimeout, Buffer, URL) - Fix all unused parameter errors by prefixing with underscore - Fix empty catch blocks with ignore comments - Remove unused imports
* chore: remove examples directory Remove all example files and update package.json scripts to exclude examples from linting and formatting. * chore: enable linting for test directories and fix all lint errors - Remove __tests__ from ESLint ignores to enable linting on test files - Add tests_integ to lint and format scripts in package.json - Exclude test files from main src ESLint config to avoid tsconfig errors - Add missing globals for test files (setTimeout, Buffer, URL) - Fix all unused parameter errors by prefixing with underscore - Fix empty catch blocks with ignore comments - Remove unused imports
* chore: remove examples directory Remove all example files and update package.json scripts to exclude examples from linting and formatting. * chore: enable linting for test directories and fix all lint errors - Remove __tests__ from ESLint ignores to enable linting on test files - Add tests_integ to lint and format scripts in package.json - Exclude test files from main src ESLint config to avoid tsconfig errors - Add missing globals for test files (setTimeout, Buffer, URL) - Fix all unused parameter errors by prefixing with underscore - Fix empty catch blocks with ignore comments - Remove unused imports
* chore: remove examples directory Remove all example files and update package.json scripts to exclude examples from linting and formatting. * chore: enable linting for test directories and fix all lint errors - Remove __tests__ from ESLint ignores to enable linting on test files - Add tests_integ to lint and format scripts in package.json - Exclude test files from main src ESLint config to avoid tsconfig errors - Add missing globals for test files (setTimeout, Buffer, URL) - Fix all unused parameter errors by prefixing with underscore - Fix empty catch blocks with ignore comments - Remove unused imports
huanshenyi
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
HI @aidandaly24 ,could you please take a look at this PR when you have a chance? |
|
Thanks for the PR! This looks good and we'll consider it when we designing the memory modules for the TypeScript SDK. Regarding the linked issue (strands-agents/sdk-typescript#332), we want to clarify that Once SessionManagement is available in the Strands TypeScript SDK, we'll do a fast follow to add |
|
@JUSTINMKAUFMAN We'd like to better understand which specific memory features from the Python SDK you're looking for:
If you're specifically looking for AgentCoreMemorySessionManager for Strands (option 3), please note that this cannot be implemented until the Strands TypeScript SDK supports SessionManagement capabilities first. We'll do a fast follow once that support is available on the Strands side. If this is what you need, please consider upvoting strands-agents/sdk-typescript#332 to help prioritize this feature in the Strands TypeScript SDK. |
4 participants
Description
This PR implements the memory module by porting the functionality from the Python SDK.
This addition is a prerequisite for enabling AgentCore memory usage within the Strands framework, addressing the requirements discussed in strands-agents/sdk-typescript#332.
It introduces the
MemorySessionManagerandMemoryControlPlaneClientto handle session management and interaction with the Bedrock Agent control plane.Changes
MemorySessionManager: Manages session lifecycle and operations.MemoryControlPlaneClient: Handles communication with the control plane service.DictWrapper: Utility for dictionary-like object handling.src/memory/directory containing all memory-related implementations.src/memory/__tests__/.uuidand@aws-sdk/client-bedrock-agentcore-control.Testing
Related Issue
Related to strands-agents/sdk-typescript#332